Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MY handler regression #478

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix MY handler regression #478

merged 2 commits into from
Oct 23, 2024

Conversation

ppinchuk
Copy link
Collaborator

If user defines "dsets" in MY collection config as a subset of all possible dsets, then some required LCOE dsets may end up missing from the output (i.e. not added to pass_through_dsets). In this PR, we pull the full set of available datasets regardless of the user input. Includes test.

@ppinchuk ppinchuk added bug Something isn't working Urgent High priority issue for NREL deliverables labels Oct 23, 2024
@ppinchuk ppinchuk self-assigned this Oct 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (df1eee5) to head (8c443a8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
reV/handlers/multi_year.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   87.52%   87.60%   +0.07%     
==========================================
  Files         122      122              
  Lines       18183    18218      +35     
==========================================
+ Hits        15915    15960      +45     
+ Misses       2268     2258      -10     
Flag Coverage Δ
unittests 87.60% <96.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk
Copy link
Collaborator Author

reVX test fails because of pandas 2.0. Moving forward with this for now

@ppinchuk ppinchuk merged commit a6c1bf7 into main Oct 23, 2024
10 of 11 checks passed
@ppinchuk ppinchuk deleted the pp/fix_my_handler_regression branch October 23, 2024 02:57
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Urgent High priority issue for NREL deliverables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants