Enh integration #27
Enh integration #27
Conversation
|
Hey Tim what does the num_point calculator supposed to do. For 3d plotting the same number of points must be present. |
|
|
| ai.setPyFAI(**config_dict) | ||
| integration_dict = {'filename':w_name, | ||
| 'polarization_factor': 0.99} | ||
| rv = ai.integrate1d(img, npt, **integration_dict) |
There was a problem hiding this comment.
Does this mean that this doesn't support masks in the integration?
There was a problem hiding this comment.
This would be something that @chiahaoliu would have to answer. I am assuming that we could support masks. The purpose of this eventual pull request is to allow for configuration files (which I believe have information about the masks in them) to be incorporated in the integration process. The current Azimuthal class is just meant to use a simple version of pyFAI to allow for quick azimuthal integration of the data. That way users can get a general feel for what their integrated patterns look like.
There was a problem hiding this comment.
Ah, ok. What is the structure of these "configuration files"?
There was a problem hiding this comment.
Good question. Meaning I have no idea
There was a problem hiding this comment.
If there is to be a "configuration file" it would be good to know what is in it so that the code could be built around it. Although for the record I am a bit skeptical of using a configuration file to manage the masks and other information.
There was a problem hiding this comment.
mask is another optional argument in integrate1d fucntion which takes a numy array. Please refer to pyFAI docstring. So far we don't have consistent way of masking and we haven't decided which way to implement yet.
I remeber you have a auto-mask function, maybe we can integrate it into this workflow
There was a problem hiding this comment.
I am aware of the function signature. My point was that you didn't leave any room for mask or any other kwargs to be passed to the pyFAI function, limiting its overall functionality and extensionability. Also please note that you hard-coded the polarization factor into the integration. You might consider leaving these as kwargs in your function with the desired defaults.
You are more than welcome to use my masking function. My version of the complete workflow is here and you are more than welcome to use it. I should be adding analysisstore capabilities to it soon.
That's a PR in progress. Basically it captures the idea of loading different calibration parameter sets per image so that we have accurate integration result. This is a file based version which aligns with current xpdView logic.
Basic functionality is ready but need to be properly added into
Azimuthalclass. I will keep working on it and we can work together on Aug. 20 too.