Support for non-gregorian calendars date formatting #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrodro83
added a commit
to elrodro83/lore-keeper
that referenced
this pull request
Jun 26, 2015
Levareage custom calendar functionality: NUKnightLab/TimelineJS#804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, i can provide the timeline with the javascript stategy i want to render the dates, by indicating the url of the js file that has that logic in the "calendar" attribute of the timeline config.
I think this is a useful feature, i remember somebody needing a hebrew calendar and there is also the question in the faq about using relative times (1 month, 2 months, etc) rather than absolute dates. This is useful for both cases.
In a couple of days i might be able to implement a couple of examples.