Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create phi3mini.py #11281

Merged
merged 11 commits into from
Nov 16, 2024
Merged

Create phi3mini.py #11281

merged 11 commits into from
Nov 16, 2024

Conversation

mayani-nv
Copy link
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks good to me. Can you expose the config and model classes in this file to various init.py? See other models for an example. The goal is to be able to do llm.Phi3Model

Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>

Apply isort and black reformatting

Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com>

Update __init__.py

Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>

Update __init__.py

Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>

Apply isort and black reformatting

Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com>
Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>

Apply isort and black reformatting

Signed-off-by: mayani-nv <mayani-nv@users.noreply.github.com>

Update phi3_mini_4k_instruct.py and removed Performant recipe

Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>

Update phi3_mini_4k_instruct.py and removing performant condition

Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>

Update phi3_mini_4k_instruct.py with docstring changes

Signed-off-by: mayani-nv <67936769+mayani-nv@users.noreply.github.com>
Copy link
Collaborator

@cuichenx cuichenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cuichenx cuichenx enabled auto-merge (squash) November 15, 2024 23:28
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

1 similar comment
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:


------------------------------------
Your code has been rated at 10.00/10

Thank you for improving NeMo's documentation!

@cuichenx cuichenx merged commit a63ea84 into NVIDIA:main Nov 16, 2024
165 of 166 checks passed
@mayani-nv mayani-nv deleted the patch-1 branch November 18, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants