Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSD-1753: Adds !important to certain styles #51

Merged
merged 1 commit into from
Jul 9, 2024
Merged

DSD-1753: Adds !important to certain styles #51

merged 1 commit into from
Jul 9, 2024

Conversation

oliviawongnyc
Copy link
Collaborator

@oliviawongnyc oliviawongnyc commented Jul 5, 2024 •
edited by jira bot
Loading

Fixes DSD-1753

This PR does the following:

  • Adds !important designation to certain styles to keep them from being overridden in consuming app.
  • Screenshot showing the problem in the libguides app (small font)
    Uploading Screenshot 2024-06-18 at 4.00.39 PM.png…

How has this been tested?

  • Locally
  • Will also need to be tested in a consuming application

Checklist:

  • I have updated the Readme documentation accordingly.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-header-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 7:52pm

EdwinGuzman
EdwinGuzman approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@EdwinGuzman EdwinGuzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same as prod.

@oliviawongnyc oliviawongnyc merged commit 344e68f into main Jul 9, 2024
3 checks passed
@oliviawongnyc oliviawongnyc deleted the DSD-1753/add-important-to-header-styles branch July 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwinGuzman EdwinGuzman EdwinGuzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviawongnyc @EdwinGuzman