Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace validation #275

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Namespace validation #275

wants to merge 5 commits into from

Conversation

kk-08
Copy link

@kk-08 kk-08 commented Jun 27, 2020 •
edited
Loading

Purpose / Goal

Adds namespace validation for XML

Closes #265

Type

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Description

Perf test results:

Before
validation : 12267.12026907211 requests/second
xml to json : 15042.8615171619 requests/second
xml to json + json string : 13716.406269165005 requests/second
xml to json string : 2662.81536578866 requests/second
xml2js : 5438.29834726833 requests/second

After
validation : 13867.26753315293 requests/second
xml to json : 16933.889511481724 requests/second
xml to json + json string : 15117.827735598856 requests/second
xml to json string : 2567.4248020602818 requests/second
xml2js : 4739.0545687362255 requests/second

@coveralls
Copy link

coveralls commented Jun 27, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 94.301% when pulling ca8ffd5 on kk-08:feature/nsValidation into c665954 on NaturalIntelligence:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.18% when pulling 3d15e7f on kk-08:feature/nsValidation into c665954 on NaturalIntelligence:master.

@kk-08 kk-08 mentioned this pull request Jun 27, 2020
Open
6 tasks
@amitguptagwl
Copy link
Member

Thanks for the PR. I'll try to test your changes ASAP.

amitguptagwl
amitguptagwl requested changes Jul 5, 2020
View reviewed changes
Copy link
Member

@amitguptagwl amitguptagwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given a few initial comments. Please check

spec/validator_spec.js Outdated Show resolved Hide resolved
spec/validator_spec.js Outdated Show resolved Hide resolved
spec/validator_spec.js Outdated Show resolved Hide resolved
@kk-08
Copy link
Author

kk-08 commented Jul 5, 2020 •
edited
Loading

@amitguptagwl Pushed a few changes. These should improve the performance as well. Please check

@kk-08
Copy link
Author

kk-08 commented Jul 16, 2020

@amitguptagwl Suggested changes pushed. Please check and update.

@kk-08 kk-08 requested a review from amitguptagwl July 18, 2020 12:19
@kk-08
Copy link
Author

kk-08 commented Aug 5, 2020

@amitguptagwl Any updates on this?

@amitguptagwl
Copy link
Member

@kk-08 Sorry for the late response. Please check v4 branch that I have pushed recently. As I had already done these changes, I'm avoiding reviewing the code for same purpose.

The changes in v4 are almost done. But I've not completed all the tests yet. As soon I migrate all the tests from master branch to v4 branch. I would be in the condition to publish them. However, there may be some additional changes before going live but that decision can be taken later.

@amitguptagwl
Copy link
Member

@kk-08 v4 is live now. And changes seem useful, could you please fix the conflicts so I can review and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitguptagwl amitguptagwl Awaiting requested review from amitguptagwl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Namespace validation is not done
3 participants
@kk-08 @coveralls @amitguptagwl