Release 1.2.2 stable.

ChangeLog

@@ -1,3 +1,48 @@
+# v 1.2.2  2022-02-25  [stable]
+
+This is a maintenance release with major bug fixes.
+
+There were several shortcomings with bandwidth management: capping was not
+performed correctly and could overuse uploading bandwidth. Also when the DHT
+is turned off or on, we need to recompute proper bandwidth stealing.
+
+Corruption of the DHT disk databases could also lead to a crash.
+
+There was a critical old bug in the Dynamic Querying layer that affected
+Ultrapeers mostly: we could corrupt memory and/or crash when the current node
+was removed and we were processing a Dynamic Query for that node.  This is
+more likely to happen when running as an Ultrapeer but it could also affect
+nodes running as leaves, although the probability of that bug happening is
+much less in that case.
+
+Finally, it is best to not iterate on a global list that could get changed
+due to a node removal.  This was the case when sending pongs to neighbouring
+nodes, so we now take a private copy.
+
+Improvements:
+- Extended "props" shell command with -e (exact) and -i (ignore missing).
+- The "props" command now takes a set of properties, handled as one batch.
+
+Bug Fixes:
+- Properly recompute bandwidth stealing on DHT changes.
+- Avoid crashing in D-Bus lib when filename is improperly UTF-8 encoded.
+- DHT: protect against corrupted database.
+- bw_available(): fix invalid logic for I/O source capping.
+- pong_all_neighbours_but_one(): iterate on local list.
+- dq_node_removed(): must free dq object asynchronously.
+
+Under the Hood:
+- Update IRC network information: moved from freenode to libera.chat
+- Chunk size limiting for uploads accounts for bandwidth.
+- Reduce memory footprint for statx_t if no data kept.
+- CQ: defer freeing of dispatched event.
+- watchdog: be more verbose within critical messages.
+- node_parse(): signal to callers when we have BYE-ed the node.
+- cq_event_called(): use better diagnostic on assert failure.
+- dbus_util_send_message(): protect against invalid text.
+- prepare_entry(): ensure entry invariant remains true.
+- wd_expire(): do nothing if watchdog was asleep.
+
 # v 1.2.1  2021-07-12  [stable]
 
 This is a maintenance release with minor bug fixes.
@@ -21,7 +66,7 @@ to store the data.
 Add properties to track bytes exchanged by schedulers.  These properties
 track the amount of bytes exchanged by session and are reset to 0 whenever
 a new user session starts.  It allows users to see the actual amount of
-data consumed by running gtk-gnutella sessions, programatically via the
+data consumed by running gtk-gnutella sessions, programmatically via the
 shell interface.
 
 Add -t switch to shell "status" command: this displays the total amount

README

@@ -71,8 +71,8 @@ The Project Page is:
 Open Discussion Forums, try:
     http://www.gnutellaforums.com/
 
-There is an IRC channel for gtk-gnutella on http://www.freenode.net:
-    irc.freenode.net #gtk-gnutella
+There is an IRC channel for gtk-gnutella on https://libera.chat:
+    irc.libera.chat #gtk-gnutella
 
 Mailing lists
 

debian/changelog

@@ -1,3 +1,9 @@
+gtk-gnutella (1.2.2-1) unstable; urgency=high
+
+  * New upstream release with major bug fixes.
+
+ -- Raphael Manfredi <Raphael_Manfredi@pobox.com>  Fri, 25 Feb 2022 07:32:37 +0000
+
 gtk-gnutella (1.2.1-1) unstable; urgency=high
 
   * New upstream release with important bug fixes.

po/POTFILES.in

@@ -1,5 +1,5 @@
 # List of source files containing translatable strings.
-# Regenerated on Mon Jul 12 21:46:20 CEST 2021
+# Regenerated on Fri Feb 25 08:30:11 CET 2022
 
 src/core/ban.c
 src/core/downloads.c
@@ -52,8 +52,6 @@ src/ui/gtk/downloads_common.c
 src/ui/gtk/filter.c
 src/ui/gtk/filter_core.c
 src/ui/gtk/gnet_stats_common.c
-src/ui/gtk/gtk-missing.c
-src/ui/gtk/gtk-shared/callbacks.c
 src/ui/gtk/gtk1/callbacks.c
 src/ui/gtk/gtk1/interface-glade.t
 src/ui/gtk/gtk1/nodes.c
@@ -72,9 +70,11 @@ src/ui/gtk/gtk2/search.c
 src/ui/gtk/gtk2/search_cb.c
 src/ui/gtk/gtk2/search_stats.c
 src/ui/gtk/gtk2/support-glade.c
-src/ui/gtk/gtk2/upload_stats.c
 src/ui/gtk/gtk2/uploads.c
+src/ui/gtk/gtk2/upload_stats.c
 src/ui/gtk/gtkcolumnchooser.c
+src/ui/gtk/gtk-missing.c
+src/ui/gtk/gtk-shared/callbacks.c
 src/ui/gtk/hcache_common.c
 src/ui/gtk/icon.c
 src/ui/gtk/main.c

po/de.po

@@ -7788,8 +7788,8 @@ msgstr "Maximum"
 msgid "Measured HTTP latency:"
 msgstr "Gemessene HTTP-Latenz:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Triff uns in #gtk-gnutella auf irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Triff uns in #gtk-gnutella auf irc.libera.chat."
 
 msgid "Min/Max:"
 msgstr ""
@@ -8981,7 +8981,7 @@ msgstr "Filter _löschen"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Triff uns in #gtk-gnutella auf irc.freenode.net."
+msgstr "Triff uns in #gtk-gnutella auf irc.libera.chat."
 
 #, fuzzy
 msgid ""

po/el.po

@@ -7781,8 +7781,8 @@ msgstr "Μέγιστο"
 msgid "Measured HTTP latency:"
 msgstr "Μέτρηση καθυστέρησης HTTP:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Βρείτε μας στο #gtk-gnutella στο irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Βρείτε μας στο #gtk-gnutella στο irc.libera.chat."
 
 msgid "Min/Max:"
 msgstr "Ελαχ/μεγ:"
@@ -8980,7 +8980,7 @@ msgstr "_Αφαίρεση φίλτρου"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Βρείτε μας στο #gtk-gnutella στο irc.freenode.net."
+msgstr "Βρείτε μας στο #gtk-gnutella στο irc.libera.chat."
 
 #, fuzzy
 msgid ""

po/es.po

@@ -8044,8 +8044,8 @@ msgstr "Máximo"
 msgid "Measured HTTP latency:"
 msgstr "Latencia HTTP medida:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Conózcanos en #gtk-gnutella en irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Conózcanos en #gtk-gnutella en irc.libera.chat."
 
 msgid "Min/Max:"
 msgstr "Mín/Máx:"
@@ -9259,7 +9259,7 @@ msgstr "_Borrar filtro"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Conózcanos en #gtk-gnutella en irc.freenode.net."
+msgstr "Conózcanos en #gtk-gnutella en irc.libera.chat."
 
 #, fuzzy
 msgid ""

po/fr.po

@@ -8252,8 +8252,8 @@ msgstr "Maximum"
 msgid "Measured HTTP latency:"
 msgstr "Latence HTTP mesurée :"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Rencontrez nous sur #gtk-gnutella sur irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Rencontrez nous sur #gtk-gnutella sur irc.libera.chat."
 
 msgid "Min/Max:"
 msgstr "Min/Max :"
@@ -9481,7 +9481,7 @@ msgstr "_Supprimer le filtre"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Rencontrez nous sur #gtk-gnutella sur irc.freenode.net."
+msgstr "Rencontrez nous sur #gtk-gnutella sur irc.libera.chat."
 
 #, fuzzy
 msgid ""

po/gtk-gnutella.pot

@@ -7408,7 +7408,7 @@ msgstr ""
 msgid "Measured HTTP latency:"
 msgstr ""
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
 msgstr ""
 
 msgid "Min/Max:"

po/hu.po

@@ -7509,8 +7509,8 @@ msgstr "Legnagyobb"
 msgid "Measured HTTP latency:"
 msgstr "Mért HTTP késés:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Találkozzznk a „#gtk-gnutella” csatornán az „irc.freenode.net”-en!"
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Találkozzznk a „#gtk-gnutella” csatornán az „irc.libera.chat”-en!"
 
 msgid "Min/Max:"
 msgstr ""
@@ -8677,7 +8677,7 @@ msgstr ""
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Találkozzznk a „#gtk-gnutella” csatornán az „irc.freenode.net”-en!"
+msgstr "Találkozzznk a „#gtk-gnutella” csatornán az „irc.libera.chat”-en!"
 
 msgid ""
 "This product includes IP2Location LITE data, available from\n"

po/it.po

@@ -8277,8 +8277,8 @@ msgstr "Massimo"
 msgid "Measured HTTP latency:"
 msgstr "Latenza HTTP misurata:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Raggiungici su #gtk-gnutella at irc.freenode.net"
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Raggiungici su #gtk-gnutella at irc.libera.chat"
 
 msgid "Min/Max:"
 msgstr "Min/Max:"
@@ -9496,7 +9496,7 @@ msgstr "_Rimuovi il filtro"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Raggiungici su #gtk-gnutella at irc.freenode.net"
+msgstr "Raggiungici su #gtk-gnutella at irc.libera.chat"
 
 #, fuzzy
 msgid ""

po/ja.po

@@ -7862,8 +7862,8 @@ msgstr "最大"
 msgid "Measured HTTP latency:"
 msgstr "計測HTTP待ち時間:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "irc.freenode.net の #gtk-gnutella でお会いしましょう。"
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "irc.libera.chat の #gtk-gnutella でお会いしましょう。"
 
 msgid "Min/Max:"
 msgstr "最小/最大:"
@@ -9073,7 +9073,7 @@ msgstr "フィルターを削除(_R)"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "irc.freenode.net の #gtk-gnutella でお会いしましょう。"
+msgstr "irc.libera.chat の #gtk-gnutella でお会いしましょう。"
 
 #, fuzzy
 msgid ""

po/nb.po

@@ -7948,8 +7948,8 @@ msgstr "Høyst"
 msgid "Measured HTTP latency:"
 msgstr "Målt HTTP-ventetid:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Møt oss i «#gtk-gnutella» på «irc.freenode.net»."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Møt oss i «#gtk-gnutella» på «irc.libera.chat»."
 
 msgid "Min/Max:"
 msgstr "Min/Maks:"
@@ -9162,7 +9162,7 @@ msgstr "Fje_rn filter"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Møt oss i «#gtk-gnutella» på «irc.freenode.net»."
+msgstr "Møt oss i «#gtk-gnutella» på «irc.libera.chat»."
 
 #, fuzzy
 msgid ""

po/nl.po

@@ -8297,8 +8297,8 @@ msgstr "Maximum"
 msgid "Measured HTTP latency:"
 msgstr "Gemeten HTTP vertraging:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Ontmoet ons op #gtk-gnutella op irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Ontmoet ons op #gtk-gnutella op irc.libera.chat."
 
 msgid "Min/Max:"
 msgstr "Min/Max:"
@@ -9526,7 +9526,7 @@ msgstr "Ve_rwijder filter"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Ontmoet ons op #gtk-gnutella op irc.freenode.net."
+msgstr "Ontmoet ons op #gtk-gnutella op irc.libera.chat."
 
 #, fuzzy
 msgid ""

po/tr.po

@@ -8241,8 +8241,8 @@ msgstr "En çok"
 msgid "Measured HTTP latency:"
 msgstr "Ölçülen HTTP gecikmesi:"
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "Bizimle irc.freenode.net #gtk-gnutella'da görüşün."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "Bizimle irc.libera.chat #gtk-gnutella'da görüşün."
 
 msgid "Min/Max:"
 msgstr "Asgari/Azami:"
@@ -9458,7 +9458,7 @@ msgstr "Filtreyi _Kaldır"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "Bizimle irc.freenode.net #gtk-gnutella'da görüşün."
+msgstr "Bizimle irc.libera.chat #gtk-gnutella'da görüşün."
 
 #, fuzzy
 msgid ""

po/uk.po

@@ -7428,7 +7428,7 @@ msgstr "Максимум"
 msgid "Measured HTTP latency:"
 msgstr ""
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
 msgstr ""
 
 msgid "Min/Max:"

po/zh_CN.po

@@ -7443,8 +7443,8 @@ msgstr "最大"
 msgid "Measured HTTP latency:"
 msgstr ""
 
-msgid "Meet us on #gtk-gnutella at irc.freenode.net."
-msgstr "通过 irc.freenode.net 上的 #gtk-gnutella 聊天室直接交流。"
+msgid "Meet us on #gtk-gnutella at irc.libera.chat."
+msgstr "通过 irc.libera.chat 上的 #gtk-gnutella 聊天室直接交流。"
 
 msgid "Min/Max:"
 msgstr "最小/最大："
@@ -8603,7 +8603,7 @@ msgstr "删除过滤器(_R)"
 
 #, fuzzy
 msgid "Meet us on #gtk-gnutella at libera.chat."
-msgstr "通过 irc.freenode.net 上的 #gtk-gnutella 聊天室直接交流。"
+msgstr "通过 irc.libera.chat 上的 #gtk-gnutella 聊天室直接交流。"
 
 #, fuzzy
 msgid ""