Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] stock_quantity_history_location #316

Merged

Conversation

AnaisLForgeFlow
Copy link

Standard Migration

@ForgeFlow

@AnaisLForgeFlow AnaisLForgeFlow force-pushed the 17.0-mig-stock_quantity_history_location branch from 61344a9 to 1efe2c6 Compare May 14, 2024 09:40
Copy link

@GuillemCForgeFlow GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the rest, functional and code review LGTM 👍🏿

@AnaisLForgeFlow AnaisLForgeFlow force-pushed the 17.0-mig-stock_quantity_history_location branch from 1efe2c6 to 760f848 Compare May 15, 2024 07:27
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@rousseldenis
Copy link
Contributor

/ocabot migration stock_quantity_history_location


@api.model
def get_views(self, views, options=None):
res = super().get_views(views, options=options)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnaisLForgeFlow Maybe a good improvement should be adding a little test calling the view.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis sure, we can add this for better test coverage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis I've just added the test case, I believe it should be ready to merge 🙂

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@LoisRForgeFlow
Copy link

@GuillemCForgeFlow can you update your review?

atchuthan and others added 19 commits October 21, 2024 11:30
Currently translated at 100.0% (6 of 6 strings)

Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_quantity_history_location/ja/
Co-authored-by: DavidJForgeFlow <david.jimenez@forgeflow.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_quantity_history_location/
Currently translated at 60.0% (3 of 5 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/it/
This commit solves the error
"Non loaded module
stock_quantity_history_location.InventoryReportListController" because
the dependency stock.InventoryReportListController was missed. The
dependency from stock was migrated to OWL [1], so it is inherited using the
OWL to preserve the behavior.

References:
- [1] odoo/odoo@ec0b1005
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/it/
Currently translated at 100.0% (5 of 5 strings)

Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/es/
@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 17.0-mig-stock_quantity_history_location branch from 760f848 to c14f7c1 Compare October 21, 2024 09:30
- refactored .js code by inheriting `get_views` method to display a different button text for those users having the Multi Locations group enabled. Added a test case to cover the change
@GuillemCForgeFlow GuillemCForgeFlow force-pushed the 17.0-mig-stock_quantity_history_location branch from c14f7c1 to f28ee0e Compare October 21, 2024 09:33
@LoisRForgeFlow
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-316-by-LoisRForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 148daea into OCA:17.0 Oct 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2536cc1. Thanks a lot for contributing to OCA. ❤️

@GuillemCForgeFlow GuillemCForgeFlow deleted the 17.0-mig-stock_quantity_history_location branch October 23, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.