Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe.md #217

Merged
merged 11 commits into from
Nov 15, 2024
Merged

Update ReadMe.md #217

merged 11 commits into from
Nov 15, 2024

Conversation

MattDonovan82
Copy link
Contributor

@MattDonovan82 MattDonovan82 commented Oct 28, 2024

Updates to multiple files and the removal of files no long required.

All updates to docs are highlighted in this issue (#206)

Update to Cyber and Liability Read Me files and the removal of obsolete files

Main updates have been to the 'read me' files for both liability and cyber. These now mention how both classes are incorporated into the main OED spec and no longer treated separate schemas in OED v4.

The pdf docs that contained much the same info as the 'Read me' files have been removed as they are no longer necessary. They were created originally to be circulated upon release of these schemas.

The original xlsx data spec docs for both liability and cyber have also been removed as they are now obsolete since as being incorporated into the main OED spec.

Updates to the cyber 'read me'
Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit feb296f
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11556642392
Excel File excel_spec.zip
JSON File extracted_spec.zip

Update and edits to the liability read me - into, rationale and taxonomy descriptions.
Copy link

github-actions bot commented Nov 6, 2024

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 8d6deef
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11703824670
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link

github-actions bot commented Nov 6, 2024

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 15a15d4
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11703865836
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link

github-actions bot commented Nov 6, 2024

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 5791a75
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11703871655
Excel File excel_spec.zip
JSON File extracted_spec.zip

deleted the cyber 'data fields' and 'data spec' docs.
Copy link

github-actions bot commented Nov 6, 2024

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit e292dbc
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11703893153
Excel File excel_spec.zip
JSON File extracted_spec.zip

Delete the liability rational .pdf doc - this is covered in the 'read me' anyway and was mainly for distribution to the community upon original launch of liability.
Copy link

github-actions bot commented Nov 6, 2024

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit ea6adf9
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11703931761
Excel File excel_spec.zip
JSON File extracted_spec.zip

Added the correct taxonomy image
Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 82c9332
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11819841912
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit e096bc4
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11839002689
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 6bb9495
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11839499145
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 87ced9a
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11854266182
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link

Build Preview

You can find files attached to the below linked Workflow Run URL (Logs).
Please note that files only stay for around 14 days!

Name Link
Commit 214f2e8
Build https://github.com/OasisLMF/ODS_OpenExposureData/actions/runs/11854420445
Excel File excel_spec.zip
JSON File extracted_spec.zip

Copy link
Contributor

@johcarter johcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please could you update the Release notes in the pull request to something meaningful before you merge? cheers

@MattDonovan82 MattDonovan82 self-assigned this Nov 15, 2024
@MattDonovan82 MattDonovan82 merged commit 0966a11 into release/4.0.0 Nov 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants