Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: manual test failing #109

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

maiminhp
Copy link
Contributor

This part fails due to KeyError for me.

This part fails due to KeyError for me.
@maiminhp maiminhp marked this pull request as ready for review April 23, 2024 18:22
@elliot-100
Copy link
Collaborator

Can you be more specific about why it's failing e.g. with an anonymised extract from message data? Interested as I plan to look at messaging next.

@maiminhp
Copy link
Contributor Author

Yeah sure, for some reason, "text" is not a valid key in message["message"]. This was a group text though

@elliot-100 elliot-100 self-requested a review April 25, 2024 15:38
Copy link
Collaborator

@elliot-100 elliot-100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my live data.

@elliot-100 elliot-100 merged commit b337d64 into Olen:main Apr 25, 2024
5 checks passed
@elliot-100
Copy link
Collaborator

Great - this tells us a bit more about variations in chat/message data structures, which at a glance do appear more complex than groups, events, etc. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants