Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CI: isort GitHub action doesn't report expected issues #116

Merged
merged 2 commits into from
May 23, 2024
Merged

Fix: CI: isort GitHub action doesn't report expected issues #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57186fd
ci: isort: use CLI interface instead of official `isort/isort-action…
elliot-100 May 21, 2024
50b80cf
ci: isort: only target `spond` and `tests` dirs, as cannot get reliab…
elliot-100 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,18 @@ jobs:
- name: Install project
run: poetry install
- name: Lint imports with isort
# By default: exit with error if imports are not properly sorted
uses: isort/isort-action@master
with:
configuration: profile = black
# Use command line due to bugs/docs gaps with official `isort/isort-action`.
# Exit with error if the code is not properly formatted; show diffs;
# `black` compatibility.
# Only target files in `spond` and `test` due to unreliable behaviour on files in
# root directory.
# Diffs reported for these files should be the same as fixes made by running
# `isort .` in the root project folder, which picks up config from
# `pyproject.toml`.
run: |
source $VENV
isort spond --check-only --diff --profile black
isort tests --check-only --diff --profile black
- name: Lint with black
# by default: exit with error if the code is not properly formatted; show diffs
uses: psf/black@stable
Expand Down