Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13, drop support for Python 3.8 #156

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

elliot-100
Copy link
Collaborator

@elliot-100 elliot-100 commented Oct 10, 2024

This PR:

  • Adds newly released Python 3.13 to CI matrix and to black target-versions
  • Removes end-of-life Python 3.8 from CI matrix and from black target-versions. This is primarily because latest black no longer supports 3.8
  • Bumps dev-dep black to latest to ensure same behaviour in dev and CI

I've done a quick check and there don't appear to be any obvious code upgrades to be made by dropping 3.8.

3.9 did introduce the | Union operator, but that's already used in the code via __future__ import annotations.

@elliot-100 elliot-100 marked this pull request as draft October 10, 2024 09:19
@elliot-100 elliot-100 changed the title CI: add Python 3.13 Add support for Python 3.13, drop support for Python 3.8 Oct 10, 2024
… `target-version`s, as black no longer supports it.
@elliot-100 elliot-100 requested a review from Olen October 10, 2024 09:46
@elliot-100 elliot-100 marked this pull request as ready for review October 10, 2024 09:47
@elliot-100
Copy link
Collaborator Author

@Olen - have asked for your review specifically for the dropping of Python 3.8. But black not supporting it seems sufficient unless there is a good reason not to.

@Olen
Copy link
Owner

Olen commented Oct 10, 2024

I can't see any reason to support 3.8
Personally I have used 3.10 and 3.12 for a long time, and the code works fine.

@elliot-100 elliot-100 merged commit 47e67a6 into Olen:main Oct 10, 2024
5 checks passed
@elliot-100 elliot-100 deleted the ci-add-python-313 branch October 10, 2024 15:14
@elliot-100 elliot-100 added the enhancement New feature or request label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants