Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "garbage" bits #355

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix for "garbage" bits #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047deb4
Fix for "garbage" bits
serges147 Nov 11, 2024
2133159
PR review fix
serges147 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/nunavut/lang/c/support/serialization.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ static inline void nunavutCopyBits(void* const dst,
uint8_t* const last_dst = pdst + length_bytes; // NOLINT NOSONAR
{{ assert('length_mod < 8U') }}
const uint8_t mask = (uint8_t)((1U << length_mod) - 1U);
// No lint for "The left operand of '&' is a garbage value" because
// these so called "garbage" bits of `*last_dst` won't be used during deserialization.
// NOLINTNEXTLINE(clang-analyzer-core.UndefinedBinaryOperatorResult)
*last_dst = (*last_dst & (uint8_t)~mask) | (*last_src & mask);
}
}
Expand Down
Loading