-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idle detection#1187 #1652
Idle detection#1187 #1652
Conversation
3a1f26c
to
a4930ee
Compare
f3c78c2
to
fcfaa51
Compare
fcfaa51
to
f1c2772
Compare
f1c2772
to
86f1ed4
Compare
4899ac9
to
0d4745a
Compare
@dennisguse let's see if I can bend my head around this issue. |
It's about not using the speed to determine if the user became idle, but a timeout (aka no distance traveled since...). My biggest issue was the KML/GPX spec (again). |
src/main/java/de/dennisguse/opentracks/services/TrackRecordingManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/dennisguse/opentracks/services/TrackRecordingManager.java
Outdated
Show resolved
Hide resolved
1532919
to
4244da1
Compare
So far it makes sense, but I don't have a full picture (for example on possible side effects). Maybe an extended test period with the nightlies? |
@pstorch I also expect some fancy behavior. I am not really sure how to continue here. |
@dennisguse have switched the OpenTracks nightly branch to |
@dennisguse have you got any feedback from this PR and nightly? For me it's working. Recorded a few tracks and some pause got recognized. I can see it now easily with the OSMDashboard trackpoints debug option. 😉 |
@pstorch Sounds great! |
@dennisguse I'm experimenting with showing the idle/pause trackpoints in the OSMDashboard nightly. Using the previous trackpoints location. So far it looks reasonable. |
4244da1
to
20665d3
Compare
@dennisguse build fails after rebase |
20665d3
to
ecbe290
Compare
androidx.mediarouter upgrade introduced dependency conflicts and the tests are broken due to recent pull request. |
ecbe290
to
f5dae77
Compare
We now have voice announcement when the user becomes idle (disabled by default). @pstorch merge or do you see any showstoppers? |
It looks good to me. I recorded a few tracks. One time I got a wrong idle detection where I was a bit slow, but I guess I just have to increase the threshold a bit. |
I was just doing a walk and 10s doesn't work too well :D |
I really like the idle announcement. 🙂 |
I also enjoy it a lot. PS also the pause visualization shows quite nicely all the traffic lights :) |
So far, idle was considered if the speed dropped below a certain criteria.
However, speed from GPS is noisy and especially for slow moving activities (like hiking), this resulted in a lot of idle detection.
This PR changes the idle detection to "time without movement" (distance covered at least minRecordingThreshold).
TODO:
import/export GPX (speed=0.0)not supported (for now) due to lack of GPS coordinatesFor legacy formats (aka prior to this change), we may create new idle TrackPoints.
NOTE: this is a breaking change as it changes the database.
Statistics for existing tracks will not be updated (only on import).