Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackListActivity: Switch to RecyclerView #1687

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Conversation

lmarz
Copy link
Contributor

@lmarz lmarz commented Sep 3, 2023

Part of: #1613

I changed the padding a bit, I hope that's ok.
Also the TrackListAdapter.java is in a suboptimal place in the ui directory. Do you have an idea for a better place?

Copy link
Member

@dennisguse dennisguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read the PR and made some comments.

Copy link
Member

@dennisguse dennisguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

One final thing: the UI is slightly off in the list.
The distance between text and the separator line below is slightly too large.

image

@dennisguse dennisguse merged commit 0cf0208 into OpenTracksApp:main Sep 14, 2023
1 check passed
@lmarz lmarz deleted the track branch September 14, 2023 20:26
@dennisguse
Copy link
Member

Nice work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants