Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app crashing when in track selection mode #1715

Conversation

virginiaprivacycoalition

This PR implements the fixes @lmarz suggested to address the crashes that happen during track selection mode (#1711).

@dennisguse
Copy link
Member

I am not sure that this is the right solution.
My gut feeling is that the information should not be fetched from the ViewHolder, but rather from the Cursor.

The problem is that the ViewHolder might be recycled (and thus null) and the Track.Id would not be available. And thus, it would be omitted from selection.

@virginiaprivacycoalition
Copy link
Author

I am not sure that this is the right solution. My gut feeling is that the information should not be fetched from the ViewHolder, but rather from the Cursor.

The problem is that the ViewHolder might be recycled (and thus null) and the Track.Id would not be available. And thus, it would be omitted from selection.

Thanks for the feedback. I should have more time tomorrow, I'll see if I can do that

@dennisguse
Copy link
Member

One more thing: the actionMode fix seems okay.
I assume that the selection implementation has to be done differently.
This might be helpful: #1711 (comment)

@dennisguse
Copy link
Member

Superseeded by 1723.

@virginiaprivacycoalition thanks for your effort!

@dennisguse dennisguse closed this Oct 8, 2023
@virginiaprivacycoalition virginiaprivacycoalition deleted the track-selection-fix branch October 8, 2023 19:03
@virginiaprivacycoalition
Copy link
Author

Of course! Love using the app, thanks to you and everyone else for all the work on it! sorry I didn't have more time to work on the appropriate fix. Maybe next time 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants