-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced ActivityType is now non-localized (i.e., English) value #1717
Conversation
@pstorch I am in need for another sanity check. |
I did a quick test. Upgrade existing tracks worked. Export and Import with the same language worked. Export and Import from different languages resulted in UNKNOWN track types (I guess as expected). |
@pstorch Sounds good. |
No obvious issues. |
@pstorch release and merge it is. |
GPXs
<type>
doesn't specify if it should contain localized or non-localized (i.e., English) content, but most applications use the non-localized approach.OpenTracks was doing the former and actually didn't store a non-localized activity type at all, but rather just the information about the icon.
What has been done:
Track.activityType
in addition toTrack.activityTypeLocalized
<type>
as activityType while the import should be able to handle activityType OR activityTypeLocalized (BREAKING CHANGE)As usual there are likely some edgy edge cases.
PS/ KML parsing using SAX is just horrible.