-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Covariance Estimation #312
Draft
tizianoGuadagnino
wants to merge
42
commits into
main
Choose a base branch
from
296-autocompute-icp-covariance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6da4049 - Browse repository at this point
Copy the full SHA 6da4049View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88727be - Browse repository at this point
Copy the full SHA 88727beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e26b2f5 - Browse repository at this point
Copy the full SHA e26b2f5View commit details -
Fix and improve ROS visualization (#285)
* Fix this madness Simplify implementation by debugging in an ego-centric way always. Since the KISS-ICP internal map is on the global coordinates, fetch the last ego-centric pose and apply it to the map. Seen from the cloud_frame_id (which is the sensor frame) everything should always work in terms of visualization, no matter the multi-sensor setup. * Now is safe to disable this by default * Simplify, borrow the header from the input pointcloud msg This actually makes the visualization closer to the Python visualizer * Disable path/odom visualization by default In the case where we are not computing the poses in an egocentric world (base_frame != "") and we are not publishing to the TF tree, then the visualization wouldn't make sense. Therefore, disable it by default * Changed my mind If someone doesn't have that particular frame defined, then the visualization won't work. Leave this default * Move responsability of handling tf frames out of Registration (#288) * Move responsability of handling tf frames out of Registration Since with this new changes PublishOdometry is the only member that requieres to know the user specified target-frame, it is not necesary to handle all this bits. This makes the implementation cleaner, easier to read and reduces the lines of code. Now RegisterFrame is a simple callback as few months ago one can read in seconds. * typo * Easier to read * We need this for LookupTransform * Remove unused variable * Revert "Remove unused variable" This reverts commit 424ee90. * Remove unnecessary check * Remove unnecessary exposed utility function from ROS API With this change this function is not exposed (which was never the intention to) to the header. This way we can also "hide" this into a private unnamed namesapces and benefit from inlining the simple function into the translation unit * Revert "Remove unnecessary exposed utility function from ROS API" This reverts commit 23cd7ef. * Revert "Remove unnecessary check" This reverts commit d1dcb48. * merge conflicts :0 * Remove unnecessary exposed utility function from ROS API (#289) * Move responsability of handling tf frames out of Registration Since with this new changes PublishOdometry is the only member that requieres to know the user specified target-frame, it is not necesary to handle all this bits. This makes the implementation cleaner, easier to read and reduces the lines of code. Now RegisterFrame is a simple callback as few months ago one can read in seconds. * typo * Easier to read * We need this for LookupTransform * Remove unused variable * Revert "Remove unused variable" This reverts commit 424ee90. * Remove unnecessary check * Remove unnecessary exposed utility function from ROS API With this change this function is not exposed (which was never the intention to) to the header. This way we can also "hide" this into a private unnamed namesapces and benefit from inlining the simple function into the translation unit * Revert "Remove unnecessary exposed utility function from ROS API" This reverts commit 23cd7ef. * Remove unnecessary exposed utility function from ROS API With this change this function is not exposed (which was never the intention to) to the header. This way we can also "hide" this into a private unnamed namesapces and benefit from inlining the simple function into the translation unit * Revert "Remove unnecessary check" This reverts commit d1dcb48. --------- Co-authored-by: tizianoGuadagnino <frevo93@gmail.com> * too many merges * Merge Rviz and Python colors * Just make the default construction more clear --------- Co-authored-by: tizianoGuadagnino <frevo93@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3eb2069 - Browse repository at this point
Copy the full SHA 3eb2069View commit details -
Configuration menu - View commit details
-
Copy full SHA for 747b28f - Browse repository at this point
Copy the full SHA 747b28fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1836b34 - Browse repository at this point
Copy the full SHA 1836b34View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0b45cf - Browse repository at this point
Copy the full SHA c0b45cfView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a5aa930 - Browse repository at this point
Copy the full SHA a5aa930View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10d4cd8 - Browse repository at this point
Copy the full SHA 10d4cd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18a290a - Browse repository at this point
Copy the full SHA 18a290aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1f3c86 - Browse repository at this point
Copy the full SHA d1f3c86View commit details -
Configuration menu - View commit details
-
Copy full SHA for c47b4a5 - Browse repository at this point
Copy the full SHA c47b4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f44998a - Browse repository at this point
Copy the full SHA f44998aView commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d01e041 - Browse repository at this point
Copy the full SHA d01e041View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c3442c - Browse repository at this point
Copy the full SHA 7c3442cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 463fbd8 - Browse repository at this point
Copy the full SHA 463fbd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21d2c76 - Browse repository at this point
Copy the full SHA 21d2c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for a20a098 - Browse repository at this point
Copy the full SHA a20a098View commit details
Commits on Mar 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 257f2b3 - Browse repository at this point
Copy the full SHA 257f2b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59b0277 - Browse repository at this point
Copy the full SHA 59b0277View commit details -
Configuration menu - View commit details
-
Copy full SHA for e26db50 - Browse repository at this point
Copy the full SHA e26db50View commit details -
Configuration menu - View commit details
-
Copy full SHA for bba7b94 - Browse repository at this point
Copy the full SHA bba7b94View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee13b4f - Browse repository at this point
Copy the full SHA ee13b4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 177373f - Browse repository at this point
Copy the full SHA 177373fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e54ebd1 - Browse repository at this point
Copy the full SHA e54ebd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e93219 - Browse repository at this point
Copy the full SHA 9e93219View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75d9b86 - Browse repository at this point
Copy the full SHA 75d9b86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21c7972 - Browse repository at this point
Copy the full SHA 21c7972View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ec519b - Browse repository at this point
Copy the full SHA 5ec519bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d38a34 - Browse repository at this point
Copy the full SHA 7d38a34View commit details -
Configuration menu - View commit details
-
Copy full SHA for c251278 - Browse repository at this point
Copy the full SHA c251278View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39ed3ba - Browse repository at this point
Copy the full SHA 39ed3baView commit details -
Configuration menu - View commit details
-
Copy full SHA for d94aae0 - Browse repository at this point
Copy the full SHA d94aae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a054b8 - Browse repository at this point
Copy the full SHA 2a054b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf8c377 - Browse repository at this point
Copy the full SHA bf8c377View commit details -
Merge remote-tracking branch 'refs/remotes/origin/296-autocompute-icp…
…-covariance' into 296-autocompute-icp-covariance
Configuration menu - View commit details
-
Copy full SHA for 89fd830 - Browse repository at this point
Copy the full SHA 89fd830View commit details -
Configuration menu - View commit details
-
Copy full SHA for f512a0d - Browse repository at this point
Copy the full SHA f512a0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13fcb56 - Browse repository at this point
Copy the full SHA 13fcb56View commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 280e9a4 - Browse repository at this point
Copy the full SHA 280e9a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b33f27f - Browse repository at this point
Copy the full SHA b33f27fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19582b8 - Browse repository at this point
Copy the full SHA 19582b8View commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3589390 - Browse repository at this point
Copy the full SHA 3589390View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.