Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Covariance Estimation #312

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    6da4049 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88727be View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e26b2f5 View commit details
    Browse the repository at this point in the history
  4. Fix and improve ROS visualization (#285)

    * Fix this madness
    
    Simplify implementation by debugging in an ego-centric way always.
    
    Since the KISS-ICP internal map is on the global coordinates, fetch the
    last ego-centric pose and apply it to the map. Seen from the
    cloud_frame_id (which is the sensor frame) everything should always work
    in terms of visualization, no matter the multi-sensor setup.
    
    * Now is safe to disable this by default
    
    * Simplify, borrow the header from the input pointcloud msg
    
    This actually makes the visualization closer to the Python visualizer
    
    * Disable path/odom visualization by default
    
    In the case where we are not computing the poses in an egocentric world
    (base_frame != "") and we are not publishing to the TF tree, then the
    visualization wouldn't make sense. Therefore, disable it by default
    
    * Changed my mind
    
    If someone doesn't have that particular frame defined, then the
    visualization won't work. Leave this default
    
    * Move responsability of handling tf frames out of Registration (#288)
    
    * Move responsability of handling tf frames out of Registration
    
    Since with this new changes PublishOdometry is the only member that
    requieres to know the user specified target-frame, it is not necesary to
    handle all this bits.
    
    This makes the implementation cleaner, easier to read and reduces the
    lines of code. Now RegisterFrame is a simple callback as few months ago
    one can read in seconds.
    
    * typo
    
    * Easier to read
    
    * We need this for LookupTransform
    
    * Remove unused variable
    
    * Revert "Remove unused variable"
    
    This reverts commit 424ee90.
    
    * Remove unnecessary check
    
    * Remove unnecessary exposed utility function from ROS API
    
    With this change this function is not exposed (which was never the
    intention to) to the header. This way we can also "hide" this into a
    private unnamed namesapces and benefit from inlining the simple function
    into the translation unit
    
    * Revert "Remove unnecessary exposed utility function from ROS API"
    
    This reverts commit 23cd7ef.
    
    * Revert "Remove unnecessary check"
    
    This reverts commit d1dcb48.
    
    * merge conflicts :0
    
    * Remove unnecessary exposed utility function from ROS API (#289)
    
    * Move responsability of handling tf frames out of Registration
    
    Since with this new changes PublishOdometry is the only member that
    requieres to know the user specified target-frame, it is not necesary to
    handle all this bits.
    
    This makes the implementation cleaner, easier to read and reduces the
    lines of code. Now RegisterFrame is a simple callback as few months ago
    one can read in seconds.
    
    * typo
    
    * Easier to read
    
    * We need this for LookupTransform
    
    * Remove unused variable
    
    * Revert "Remove unused variable"
    
    This reverts commit 424ee90.
    
    * Remove unnecessary check
    
    * Remove unnecessary exposed utility function from ROS API
    
    With this change this function is not exposed (which was never the
    intention to) to the header. This way we can also "hide" this into a
    private unnamed namesapces and benefit from inlining the simple function
    into the translation unit
    
    * Revert "Remove unnecessary exposed utility function from ROS API"
    
    This reverts commit 23cd7ef.
    
    * Remove unnecessary exposed utility function from ROS API
    
    With this change this function is not exposed (which was never the
    intention to) to the header. This way we can also "hide" this into a
    private unnamed namesapces and benefit from inlining the simple function
    into the translation unit
    
    * Revert "Remove unnecessary check"
    
    This reverts commit d1dcb48.
    
    ---------
    
    Co-authored-by: tizianoGuadagnino <frevo93@gmail.com>
    
    * too many merges
    
    * Merge Rviz and Python colors
    
    * Just make the default construction more clear
    
    ---------
    
    Co-authored-by: tizianoGuadagnino <frevo93@gmail.com>
    nachovizzo and tizianoGuadagnino committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    3eb2069 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    747b28f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1836b34 View commit details
    Browse the repository at this point in the history
  7. Fix merge

    tizianoGuadagnino committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    c0b45cf View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. More cosmesis

    tizianoGuadagnino committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    a5aa930 View commit details
    Browse the repository at this point in the history
  2. Pybind the estimate

    tizianoGuadagnino committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    10d4cd8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18a290a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d1f3c86 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c47b4a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f44998a View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    d01e041 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c3442c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    463fbd8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    21d2c76 View commit details
    Browse the repository at this point in the history
  5. Simplify

    tizianoGuadagnino committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a20a098 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Now it makes sense

    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    257f2b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59b0277 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e26db50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bba7b94 View commit details
    Browse the repository at this point in the history
  5. Fix merge

    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    ee13b4f View commit details
    Browse the repository at this point in the history
  6. More cosmesis

    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    177373f View commit details
    Browse the repository at this point in the history
  7. Pybind the estimate

    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e54ebd1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9e93219 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    75d9b86 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    21c7972 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5ec519b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7d38a34 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c251278 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    39ed3ba View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d94aae0 View commit details
    Browse the repository at this point in the history
  16. Simplify

    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    2a054b8 View commit details
    Browse the repository at this point in the history
  17. Now it makes sense

    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    bf8c377 View commit details
    Browse the repository at this point in the history
  18. Merge remote-tracking branch 'refs/remotes/origin/296-autocompute-icp…

    …-covariance' into 296-autocompute-icp-covariance
    tizianoGuadagnino committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    89fd830 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f512a0d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    13fcb56 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Configuration menu
    Copy the full SHA
    280e9a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b33f27f View commit details
    Browse the repository at this point in the history
  3. Fix isort

    tizianoGuadagnino committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    19582b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Better match comments

    benemer committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3589390 View commit details
    Browse the repository at this point in the history