feat:types for map #1856
Merged
feat:types for map #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
mohitb35
requested changes
Sep 7, 2023
src/features/user/TreeMapper/Import/components/PlantingLocation.tsx
Outdated
Show resolved
Hide resolved
src/features/user/TreeMapper/Import/components/PlantingLocation.tsx
Outdated
Show resolved
Hide resolved
src/features/user/TreeMapper/Import/components/MapComponent.tsx
Outdated
Show resolved
Hide resolved
mohitb35
requested changes
Sep 28, 2023
There was a problem hiding this comment.
@sunilsabatp Please take a look at the open comments here and previous ones as well
src/features/user/RegisterTrees/RegisterTrees/SingleContribution.tsx
Outdated
Show resolved
Hide resolved
prachigarg19
requested changes
Dec 6, 2023
prachigarg19
requested changes
Dec 7, 2023
src/features/user/RegisterTrees/RegisterTrees/SingleContribution.tsx
Outdated
Show resolved
Hide resolved
|
In register trees, when I added a larger number like |
prachigarg19
requested changes
Dec 14, 2023
I am not encountering this error, could you please give me a demo instead ? |
| @@ -186,8 +191,12 @@ export default function ProjectsMap(): ReactElement { | |||
| </div> | |||
| {showDetails.show && ( | |||
| <Popup | |||
| latitude={showDetails.coordinates[1]} | |||
| longitude={showDetails.coordinates[0]} | |||
| latitude={ | |||
There was a problem hiding this comment.
On line number 161 onStateChange is not a part of the MapGL props
| const [open, setOpen] = React.useState(false); | ||
| const buttonRef = React.useRef<HTMLButtonElement>(null); | ||
| const { embed, callbackUrl } = React.useContext(ParamsContext); | ||
|
|
||
| const handleClose = () => { | ||
| setOpen(false); | ||
| }; |
There was a problem hiding this comment.
In markerBackgroundColor parameter project implicitly has an 'any'
| @@ -30,6 +30,7 @@ export default function PlantLocations(): ReactElement { | |||
| const { i18n, t } = useTranslation(['maps', 'common']); | |||
|
|
|||
| const openPl = (pl: PlantLocationSingle | SamplePlantLocation) => { | |||
| console.log(pl, '=='); | |||
| @@ -231,7 +232,10 @@ export default function PlantLocations(): ReactElement { | |||
| {viewport.zoom > 14 && ( | |||
| <div | |||
| key={`${pl.id}-marker`} | |||
| onClick={() => openPl(pl)} | |||
| onClick={() => { | |||
| console.log('I ran'); | |||
| @@ -100,6 +110,8 @@ export default function MapComponent({ | |||
| width: '100%', | |||
| }} | |||
| > | |||
| {/* NOTE: this functionality does not seem to work locally using React 18. | |||
| To test, a temporary fix is to set `reactStrictMode=false` in next.config.js */} | |||
There was a problem hiding this comment.
There is no on props in DrawControl's DrawControlProps
| @@ -105,65 +90,22 @@ export default function MapComponent({ | |||
| }} | |||
There was a problem hiding this comment.
no need to disable eslint on line 86
| @@ -1,21 +1,26 @@ | |||
| import React, { ReactElement } from 'react'; | |||
| import TransactionListLoader from '../../../../../public/assets/images/icons/TransactionListLoader'; | |||
| import TransactionsNotFound from '../../../../../public/assets/images/icons/TransactionsNotFound'; | |||
| import PlantLocation from './PlantLocation'; | |||
| import styles from '../TreeMapper.module.scss'; | |||
| import { useTranslation } from 'next-i18next'; | |||
| import { | |||
| SamplePlantLocation, | |||
| } | ||
| longitude={ | ||
| showDetails?.coordinates ? showDetails?.coordinates[1] : 0 | ||
| } |
There was a problem hiding this comment.
Cleanup needed for DetailsType
mohitb35
approved these changes
Jan 24, 2024
Shreyaschorge
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix -> types error for maps