Add action for checking changelog updates #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0uriest
added
skip_changelog
f0uriest
requested review from
a team,
rahulgaur104,
ddudt,
dpanici,
kianorr,
sinaatalay,
unalmis and
YigitElma
and removed request for
a team
YigitElma
requested changes
Nov 12, 2024
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip_changelog') }} |
There was a problem hiding this comment.
Adding filter for changed files could save time here
- name: Filter changes
id: changes
uses: dorny/paths-filter@v3
with:
filters: |
has_changes:
- 'desc/**'
For the changelog, we don't want to include the changes in other folders anyway.
There was a problem hiding this comment.
this whole action takes a few seconds so don't think its really worth it.
There was a problem hiding this comment.
By time, I mean adding the flag. If this test runs for every PR and fails, then that small red cross could be annoying :)
YigitElma
approved these changes
Nov 13, 2024
dpanici
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GH action that ensures
CHANGELOG.mdis updated with each PR, unless the PR is labelledskip_changelogResolves #1340