Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let linspace_XXX take in check_intersection #1401

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Let linspace_XXX take in check_intersection #1401

merged 1 commit into from
Nov 19, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Nov 18, 2024

Resolves #1400

@dpanici dpanici added easy Short and simple to code or review skip_changelog No need to update changelog on this PR labels Nov 18, 2024
@dpanici dpanici requested review from a team, rahulgaur104, f0uriest, ddudt, kianorr, sinaatalay, unalmis and YigitElma and removed request for a team November 18, 2024 21:28
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (0b52a24) to head (0b8a1d7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1401   +/-   ##
=======================================
  Coverage   95.51%   95.52%           
=======================================
  Files          96       96           
  Lines       24029    24029           
=======================================
+ Hits        22951    22953    +2     
+ Misses       1078     1076    -2     
Files with missing lines Coverage Δ
desc/coils.py 97.47% <100.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 18, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_midres         |     +0.53 +/- 7.62     | +3.30e-03 +/- 4.77e-02 |  6.30e-01 +/- 2.1e-02  |  6.27e-01 +/- 4.3e-02  |
 test_build_transform_fft_highres        |     +1.05 +/- 5.65     | +1.02e-02 +/- 5.51e-02 |  9.86e-01 +/- 3.4e-02  |  9.76e-01 +/- 4.4e-02  |
 test_equilibrium_init_lowres            |     +1.78 +/- 4.70     | +7.01e-02 +/- 1.86e-01 |  4.02e+00 +/- 8.0e-02  |  3.95e+00 +/- 1.7e-01  |
 test_objective_compile_atf              |     +1.03 +/- 3.04     | +8.19e-02 +/- 2.42e-01 |  8.06e+00 +/- 1.4e-01  |  7.98e+00 +/- 2.0e-01  |
 test_objective_compute_atf              |     -1.47 +/- 3.29     | -1.57e-04 +/- 3.52e-04 |  1.05e-02 +/- 3.0e-04  |  1.07e-02 +/- 1.9e-04  |
 test_objective_jac_atf                  |     +1.67 +/- 2.19     | +3.15e-02 +/- 4.15e-02 |  1.92e+00 +/- 2.9e-02  |  1.89e+00 +/- 2.9e-02  |
 test_perturb_1                          |     -3.12 +/- 3.79     | -4.53e-01 +/- 5.51e-01 |  1.41e+01 +/- 2.6e-01  |  1.45e+01 +/- 4.9e-01  |
 test_proximal_jac_atf                   |     -0.46 +/- 0.92     | -3.76e-02 +/- 7.50e-02 |  8.14e+00 +/- 4.9e-02  |  8.17e+00 +/- 5.7e-02  |
 test_proximal_freeb_compute             |     -0.65 +/- 1.09     | -1.30e-03 +/- 2.17e-03 |  1.99e-01 +/- 1.4e-03  |  2.00e-01 +/- 1.6e-03  |
 test_build_transform_fft_lowres         |     -0.89 +/- 5.49     | -4.85e-03 +/- 2.98e-02 |  5.39e-01 +/- 2.2e-02  |  5.43e-01 +/- 2.1e-02  |
 test_equilibrium_init_medres            |     +0.91 +/- 3.26     | +3.92e-02 +/- 1.40e-01 |  4.33e+00 +/- 1.1e-01  |  4.29e+00 +/- 8.6e-02  |
 test_equilibrium_init_highres           |     +0.33 +/- 3.64     | +1.88e-02 +/- 2.05e-01 |  5.64e+00 +/- 1.4e-01  |  5.62e+00 +/- 1.5e-01  |
 test_objective_compile_dshape_current   |     +0.50 +/- 2.16     | +1.97e-02 +/- 8.54e-02 |  3.98e+00 +/- 4.6e-02  |  3.96e+00 +/- 7.2e-02  |
 test_objective_compute_dshape_current   |     +0.02 +/- 1.60     | +7.54e-07 +/- 5.80e-05 |  3.62e-03 +/- 4.5e-05  |  3.62e-03 +/- 3.6e-05  |
 test_objective_jac_dshape_current       |     -0.25 +/- 9.79     | -9.96e-05 +/- 3.94e-03 |  4.02e-02 +/- 2.4e-03  |  4.03e-02 +/- 3.1e-03  |
 test_perturb_2                          |     -0.09 +/- 1.51     | -1.70e-02 +/- 2.96e-01 |  1.96e+01 +/- 1.5e-01  |  1.96e+01 +/- 2.6e-01  |
 test_proximal_freeb_jac                 |     +1.51 +/- 1.47     | +1.13e-01 +/- 1.10e-01 |  7.64e+00 +/- 9.0e-02  |  7.52e+00 +/- 6.3e-02  |
 test_solve_fixed_iter                   |     +0.71 +/- 60.57    | +3.56e-02 +/- 3.05e+00 |  5.07e+00 +/- 2.1e+00  |  5.03e+00 +/- 2.2e+00  |

@dpanici dpanici merged commit ff9d414 into master Nov 19, 2024
29 of 31 checks passed
@dpanici dpanici deleted the dp/coil-check branch November 19, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review skip_changelog No need to update changelog on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing in of check_intersection to CoilSet.linspaced methods
2 participants