Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Benchmarks #605

Merged
merged 6 commits into from
Aug 2, 2023
Merged

Fix Benchmarks #605

merged 6 commits into from
Aug 2, 2023

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Aug 1, 2023

closes #595

@dpanici dpanici added the run_benchmarks Run timing benchmarks on this PR against current master branch label Aug 1, 2023
@dpanici dpanici added run_benchmarks Run timing benchmarks on this PR against current master branch and removed run_benchmarks Run timing benchmarks on this PR against current master branch labels Aug 1, 2023
@dpanici dpanici added run_benchmarks Run timing benchmarks on this PR against current master branch and removed run_benchmarks Run timing benchmarks on this PR against current master branch labels Aug 1, 2023
@dpanici dpanici added run_benchmarks Run timing benchmarks on this PR against current master branch and removed run_benchmarks Run timing benchmarks on this PR against current master branch labels Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #605 (a16fe90) into master (d76d9dd) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
- Coverage   94.21%   94.21%   -0.01%     
==========================================
  Files          74       74              
  Lines       17646    17646              
==========================================
- Hits        16626    16625       -1     
- Misses       1020     1021       +1     

see 1 file with indirect coverage changes

@dpanici dpanici marked this pull request as ready for review August 2, 2023 18:03
@dpanici dpanici merged commit f68f157 into master Aug 2, 2023
19 checks passed
@dpanici
Copy link
Collaborator Author

dpanici commented Aug 2, 2023

force merged this because it only affects the benchmarks and not any of the code, and I need to have the changes in Master to test that the run_benchmarks label works

@f0uriest f0uriest deleted the dp/fix-benchmarks branch August 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_benchmarks Run timing benchmarks on this PR against current master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timing benchmarks fail
1 participant