Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shared transforms between R, Z, lambda #916

Merged
merged 6 commits into from
Mar 2, 2024
Merged

Conversation

f0uriest
Copy link
Member

@f0uriest f0uriest commented Mar 1, 2024

Resolves #812

Copy link
Contributor

github-actions bot commented Mar 1, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -0.14 +/- 2.50     | -1.74e-05 +/- 3.15e-04 |  1.26e-02 +/- 8.0e-05  |  1.26e-02 +/- 3.0e-04  |
 test_build_transform_fft_midres         |     +0.21 +/- 2.12     | +1.93e-04 +/- 1.92e-03 |  9.09e-02 +/- 1.3e-03  |  9.07e-02 +/- 1.4e-03  |
 test_build_transform_fft_highres        |     -1.37 +/- 0.82     | -6.26e-03 +/- 3.75e-03 |  4.52e-01 +/- 3.3e-03  |  4.58e-01 +/- 1.8e-03  |
+test_equilibrium_init_lowres            |    -31.42 +/- 1.45     | -1.90e-01 +/- 8.76e-03 |  4.14e-01 +/- 6.3e-03  |  6.03e-01 +/- 6.0e-03  |
+test_equilibrium_init_medres            |    -38.11 +/- 1.05     | -4.67e-01 +/- 1.29e-02 |  7.59e-01 +/- 1.0e-02  |  1.23e+00 +/- 8.1e-03  |
+test_equilibrium_init_highres           |    -44.07 +/- 0.87     | -1.83e+00 +/- 3.61e-02 |  2.32e+00 +/- 2.3e-02  |  4.14e+00 +/- 2.8e-02  |
 test_objective_compile_dshape_current   |     +0.36 +/- 0.75     | +1.66e-02 +/- 3.44e-02 |  4.63e+00 +/- 2.2e-02  |  4.61e+00 +/- 2.7e-02  |
 test_objective_compile_atf              |     -0.11 +/- 3.23     | -9.88e-03 +/- 2.98e-01 |  9.22e+00 +/- 1.3e-01  |  9.23e+00 +/- 2.7e-01  |
 test_objective_compute_dshape_current   |     +5.67 +/- 4.22     | +3.69e-04 +/- 2.74e-04 |  6.87e-03 +/- 1.2e-04  |  6.50e-03 +/- 2.5e-04  |
 test_objective_compute_atf              |     +3.84 +/- 1.88     | +5.09e-04 +/- 2.50e-04 |  1.38e-02 +/- 1.6e-04  |  1.33e-02 +/- 1.9e-04  |
 test_objective_jac_dshape_current       |     -2.28 +/- 7.49     | -1.09e-03 +/- 3.57e-03 |  4.65e-02 +/- 2.4e-03  |  4.76e-02 +/- 2.6e-03  |
 test_objective_jac_atf                  |     -3.18 +/- 4.23     | -6.52e-02 +/- 8.67e-02 |  1.98e+00 +/- 4.0e-02  |  2.05e+00 +/- 7.7e-02  |
+test_perturb_1                          |     -1.91 +/- 0.58     | -2.59e-01 +/- 7.86e-02 |  1.33e+01 +/- 6.0e-02  |  1.36e+01 +/- 5.1e-02  |
 test_perturb_2                          |     -1.06 +/- 0.68     | -2.05e-01 +/- 1.32e-01 |  1.92e+01 +/- 1.2e-01  |  1.94e+01 +/- 5.9e-02  |
 test_proximal_jac_atf                   |     +0.49 +/- 1.53     | +3.31e-02 +/- 1.03e-01 |  6.79e+00 +/- 7.8e-02  |  6.76e+00 +/- 6.8e-02  |
 test_proximal_freeb_compute             |     +2.50 +/- 1.46     | +3.01e-03 +/- 1.75e-03 |  1.24e-01 +/- 1.2e-03  |  1.21e-01 +/- 1.3e-03  |
 test_proximal_freeb_jac                 |     +0.85 +/- 4.57     | +6.87e-02 +/- 3.69e-01 |  8.14e+00 +/- 3.6e-01  |  8.07e+00 +/- 7.7e-02  |

desc/compute/utils.py Outdated Show resolved Hide resolved
dpanici
dpanici previously approved these changes Mar 2, 2024
rahulgaur104
rahulgaur104 previously approved these changes Mar 2, 2024
Copy link
Collaborator

@rahulgaur104 rahulgaur104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge if all tests have passed.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (9f7e8f5) to head (5ed92f7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   95.05%   95.10%   +0.04%     
==========================================
  Files          83       83              
  Lines       20970    20980      +10     
==========================================
+ Hits        19934    19953      +19     
+ Misses       1036     1027       -9     
Files Coverage Δ
desc/compute/utils.py 96.21% <100.00%> (+0.13%) ⬆️
desc/transform.py 93.27% <100.00%> (+2.39%) ⬆️

@f0uriest f0uriest merged commit 50e805d into master Mar 2, 2024
17 checks passed
@f0uriest f0uriest deleted the rc/transform_reuse branch March 2, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-use transforms for Z, lambda
3 participants