Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temp dir for io test #918

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Use temp dir for io test #918

merged 2 commits into from
Mar 2, 2024

Conversation

f0uriest
Copy link
Member

@f0uriest f0uriest commented Mar 1, 2024

No description provided.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (70001bc) to head (209be29).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #918   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files          83       83           
  Lines       20970    20970           
=======================================
  Hits        19934    19934           
  Misses       1036     1036           

Copy link
Contributor

github-actions bot commented Mar 1, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -1.40 +/- 1.14     | -1.78e-04 +/- 1.45e-04 |  1.25e-02 +/- 1.1e-04  |  1.27e-02 +/- 9.6e-05  |
 test_build_transform_fft_midres         |     -0.35 +/- 1.24     | -3.24e-04 +/- 1.14e-03 |  9.11e-02 +/- 1.0e-03  |  9.14e-02 +/- 4.8e-04  |
 test_build_transform_fft_highres        |     +0.85 +/- 1.73     | +3.90e-03 +/- 7.93e-03 |  4.62e-01 +/- 7.0e-03  |  4.58e-01 +/- 3.8e-03  |
 test_equilibrium_init_lowres            |     -0.68 +/- 1.91     | -4.11e-03 +/- 1.15e-02 |  5.98e-01 +/- 1.1e-02  |  6.02e-01 +/- 3.5e-03  |
 test_equilibrium_init_medres            |     -0.26 +/- 1.18     | -3.15e-03 +/- 1.44e-02 |  1.22e+00 +/- 9.8e-03  |  1.22e+00 +/- 1.1e-02  |
 test_equilibrium_init_highres           |     +0.51 +/- 1.10     | +2.10e-02 +/- 4.53e-02 |  4.15e+00 +/- 3.2e-02  |  4.13e+00 +/- 3.2e-02  |
 test_objective_compile_dshape_current   |     -0.07 +/- 1.20     | -3.03e-03 +/- 5.49e-02 |  4.57e+00 +/- 5.3e-02  |  4.57e+00 +/- 1.3e-02  |
 test_objective_compile_atf              |     -0.90 +/- 3.27     | -8.37e-02 +/- 3.02e-01 |  9.18e+00 +/- 2.0e-01  |  9.26e+00 +/- 2.2e-01  |
 test_objective_compute_dshape_current   |     -1.63 +/- 1.09     | -1.05e-04 +/- 7.07e-05 |  6.38e-03 +/- 5.8e-05  |  6.49e-03 +/- 4.1e-05  |
 test_objective_compute_atf              |     +1.22 +/- 1.61     | +1.60e-04 +/- 2.11e-04 |  1.33e-02 +/- 1.7e-04  |  1.31e-02 +/- 1.3e-04  |
 test_objective_jac_dshape_current       |     +4.20 +/- 6.79     | +1.90e-03 +/- 3.07e-03 |  4.71e-02 +/- 1.9e-03  |  4.52e-02 +/- 2.4e-03  |
 test_objective_jac_atf                  |     -2.48 +/- 2.50     | -5.22e-02 +/- 5.25e-02 |  2.05e+00 +/- 4.7e-02  |  2.10e+00 +/- 2.4e-02  |
 test_perturb_1                          |     -0.09 +/- 0.95     | -1.25e-02 +/- 1.27e-01 |  1.33e+01 +/- 3.5e-02  |  1.33e+01 +/- 1.2e-01  |
 test_perturb_2                          |     -0.70 +/- 2.19     | -1.34e-01 +/- 4.21e-01 |  1.91e+01 +/- 2.9e-01  |  1.92e+01 +/- 3.1e-01  |
 test_proximal_jac_atf                   |     -0.04 +/- 1.45     | -2.95e-03 +/- 9.79e-02 |  6.76e+00 +/- 5.7e-02  |  6.77e+00 +/- 7.9e-02  |
 test_proximal_freeb_compute             |     +0.89 +/- 1.23     | +1.07e-03 +/- 1.48e-03 |  1.21e-01 +/- 1.1e-03  |  1.20e-01 +/- 1.0e-03  |
 test_proximal_freeb_jac                 |     +0.85 +/- 2.10     | +6.77e-02 +/- 1.68e-01 |  8.07e+00 +/- 1.5e-01  |  8.00e+00 +/- 8.0e-02  |

dpanici
dpanici previously approved these changes Mar 2, 2024
@f0uriest f0uriest requested a review from dpanici March 2, 2024 00:32
@f0uriest f0uriest merged commit 9f7e8f5 into master Mar 2, 2024
17 checks passed
@f0uriest f0uriest deleted the rc/hotfix branch March 2, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants