This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
added "joined at" to member leave notifications #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
31a56d1
|
| Status: | ⚡️ Build in progress... |
|
Code Climate has analyzed commit 31a56d1 and detected 0 issues on this pull request. View more on Code Climate. |
Tristan-H11
suggested changes
Feb 22, 2023
| @@ -24,7 +24,8 @@ message_id: Message ID | |||
| created_at: Created At | |||
|
|
|||
| member_joined_server: "{} ({}) just joined the server!" | |||
| member_left_server: "**{}** just left the server!" | |||
| member_left_server_with_joined: "**{}** ({}) just left the server! Latest join was at {}" | |||
There was a problem hiding this comment.
Suggested change
| member_left_server_with_joined: "**{}** ({}) just left the server! Latest join was at {}" | |
| member_left_server_with_joined: "**{}** ({}) just left the server! The most recent join occurred at {}." |
Or even better: "The most recent join occurred on 02/24/2023 at 15:00:00."
This template makes use of the correct prepositions.
| @@ -310,7 +310,12 @@ async def on_member_remove(self, member: Member): | |||
| if (log_channel := await self.get_logging_channel(LoggingSettings.member_leave_channel)) is None: | |||
| return | |||
|
|
|||
| await log_channel.send(t.member_left_server(member)) | |||
| if join := member.joined_at: | |||
There was a problem hiding this comment.
Suggested change
| if join := member.joined_at: | |
| if joinDate := member.joined_at: |
| await log_channel.send(t.member_left_server(member)) | ||
| if join := member.joined_at: | ||
| await log_channel.send( | ||
| t.member_left_server_with_joined(member, member.id, join.strftime("%m/%d/%Y, %H:%M:%S")) |
There was a problem hiding this comment.
Suggested change
| t.member_left_server_with_joined(member, member.id, join.strftime("%m/%d/%Y, %H:%M:%S")) | |
| t.member_left_server_with_joined(member, member.id, joinDate.strftime("%m/%d/%Y, %H:%M:%S")) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds additional information for the member leave notifications
It will add the latest join of the member to the message.