Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-62] Add trestle-bot workflows for autosync catalogs and profiles #64

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

gvauter
Copy link
Member

@gvauter gvauter commented May 23, 2024

This PR adds two new GitHub action workflows using the Trestle-Bot autosync command. One is for syncing catalog content and the second is for syncing profile content. These actions are executed upon a new pull request into the main branch.

Test runs:

@gvauter gvauter requested a review from jpower432 May 23, 2024 13:40
@gvauter gvauter requested a review from a team as a code owner May 23, 2024 13:40
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some details I missed in my initial review

oscal_model: "catalog"
file_pattern: "*.json,markdown/*"
branch: ${{ github.head_ref }}
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this on my initial review. You do not need to specific the github_token unless there is an API interaction. For git authentication only (i.e. commit pushes) action/checkout handles this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit.

oscal_model: "profile"
file_pattern: "*.json,markdown/*"
branch: ${{ github.head_ref }}
github_token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit.

@gvauter gvauter requested a review from jpower432 June 3, 2024 19:15
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvauter gvauter merged commit eaae179 into main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants