-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-62] Add trestle-bot workflows for autosync catalogs and profiles #64
[ISSUE-62] Add trestle-bot workflows for autosync catalogs and profiles #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some details I missed in my initial review
oscal_model: "catalog" | ||
file_pattern: "*.json,markdown/*" | ||
branch: ${{ github.head_ref }} | ||
github_token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this on my initial review. You do not need to specific the github_token
unless there is an API interaction. For git authentication only (i.e. commit pushes) action/checkout
handles this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest commit.
oscal_model: "profile" | ||
file_pattern: "*.json,markdown/*" | ||
branch: ${{ github.head_ref }} | ||
github_token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds two new GitHub action workflows using the Trestle-Bot autosync command. One is for syncing catalog content and the second is for syncing profile content. These actions are executed upon a new pull request into the main branch.
Test runs: