Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for import of cloudfoundry_domain #184

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

ANUGRAHG
Copy link
Member

@ANUGRAHG ANUGRAHG commented Nov 18, 2024

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
make test

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Project board and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up issues are created and linked.

@ANUGRAHG ANUGRAHG added the enhancement New feature or request label Nov 18, 2024
@ANUGRAHG ANUGRAHG added this to the v0.2.0-beta1 milestone Nov 18, 2024
@ANUGRAHG ANUGRAHG self-assigned this Nov 18, 2024
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit ebbf9ee into main Nov 19, 2024
9 of 10 checks passed
@lechnerc77 lechnerc77 deleted the domains branch November 19, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Cloud Foundry - Support import of cloudfoundry_domain
2 participants