Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant export code #38

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

  • Reafactor file import code to avoid copy&paste of code
  • Centralize logic for import block creation

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[X] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
make test
  • Additional test steps
Execute import via file

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • Import via file works without regression

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Project board and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up issues are created and linked.

@lechnerc77 lechnerc77 changed the title refactor: dublicate export code refactor: remove redundant export code Sep 13, 2024
@lechnerc77 lechnerc77 self-assigned this Sep 13, 2024
@lechnerc77 lechnerc77 merged commit 10e5cbe into main Sep 13, 2024
7 checks passed
@lechnerc77 lechnerc77 deleted the refactor/exportfile branch September 13, 2024 14:17
@lechnerc77 lechnerc77 added ignore-for-release All things not to be mentioned in release notes refactoring refactoring - no changes to functionality labels Sep 17, 2024
@lechnerc77 lechnerc77 added this to the v0.1.0-beta1 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release All things not to be mentioned in release notes refactoring refactoring - no changes to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant