fix: Don't pass fullName for Unlocked packages

[jstvz]

This PR fixes an issue where the creation of a beta version of an unlocked package was failing during the create_package_version task with a misleading error message about a 1GP dependency.

The workaround is to match the behavior of the @salesforce/packaging typescript library: when the package type is 'unlocked', 'None' is passed instead of the package name.

Fixes #3633

[davidmreed]

@jstvz do we have any confirmation that this is the same behavior as sfdx? There's a Deep Magic bug that manifests roughly the same way but which I don't think has the same underlying cause.

[jstvz]

@jstvz do we have any confirmation that this is the same behavior as sfdx? There's a Deep Magic bug that manifests roughly the same way but which I don't think has the same underlying cause.

Yes, as far as I can tell.

The source conversion happens during package version create. It calls MetadataConverter from source-deploy-retrieve using the convertMetadata function. This function is only called by generateMDFolderForArtifact.

I found two callers of generateMDFolderForArtifact. Both construct the options without including the packageName. In contrast, when force:source:convert -n pkgName is called, packageName is included.

[davidmreed]

@jstvz Given your findings should this apply for any 2GP package, not just Unlocked?

[jstvz]

@davidmreed I believe we should limit it to just Unlocked packages because of: (1) the blast radius and, (2) there are no issues reporting similar behavior in 2GP packages (despite the scale at which we've been building them).

[leboff]

@jstvz @davidmreed to your question, this does not just affect unlocked packages. My original bug report was for a locked 2GP, and I verified this error is still occurring on CCI 3.83.0