Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to AndroidX Media3 1.5.0 #794

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Nov 18, 2024

Pull request

Description

Update the AndroidX Media3 dependency to 1.5.0.

Changes made

  • Update to AndroidX Media3 1.5.0 and Guava to 33.3.1.
  • Update usages of the removed DefaultPreloadManager.Status.STAGE_LOADED_TO_POSITION_MS constant in favor of DefaultPreloadManager.Status.STAGE_LOADED_FOR_DURATION_MS.
  • Update PillarboxLoadControl to override the new onTracksSelected() and shouldContinuePreloading methods.
  • Update PillarboxPreloadManager to use DefaultPreloadManager.Builder instead of the deprecated DefaultPreloadManager constructor.
  • Update PillarboxMediaController to remove removed methods.
  • Disable Guava updates through Dependabot. Guava is updated at the same time as AndroidX Media3.

Note

This is a draft, since AndroidX Media3 is currently in RC.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 added the dependencies Pull requests that update a dependency file label Nov 18, 2024
@MGaetan89 MGaetan89 self-assigned this Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Code Coverage

Overall Project 48.43% -0.13% 🟢
Files changed 64.22% 🟢

Module Coverage
:pillarbox-core-business 83.99% -0.04% 🟢
:pillarbox-player 56.59% -0.24% 🟢
Files
Module File Coverage
:pillarbox-core-business CommandersActStreaming.kt 96.04% -0.29% 🟢
:pillarbox-player PillarboxPreloadManager.kt 85.88% -7.34% 🟢
PillarboxLoadControl.kt 78.38% -6.49% 🟢
PillarboxExoPlayer.kt 72.95% 🟢
PillarboxMediaController.kt 0% -0.66% 🟢

@MGaetan89 MGaetan89 force-pushed the androidx_media3_1.5.0 branch 2 times, most recently from b72d98f to 55e3c0f Compare November 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: 🚧 In Progress
Development

Successfully merging this pull request may close these issues.

1 participant