Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add punctuation. #61

Merged
merged 6 commits into from
Feb 26, 2024
Merged

Conversation

gabevenberg
Copy link
Contributor

@gabevenberg gabevenberg commented Feb 15, 2024

fixes #60, thanks for having a very clear, easy to work with codebase!

  • WordSelector implementation
  • command line options added
  • README documentation

Copy link
Owner

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for the contribution.

I just have one question ⬇️. Looks good to merge otherwise.

src/textgen.rs Outdated Show resolved Hide resolved
Copy link
Owner

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Samyak2 Samyak2 merged commit e1e0763 into Samyak2:main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for punctuation
2 participants