Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to GSL 2.0 #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adapt to GSL 2.0 #31

wants to merge 5 commits into from

Conversation

boutil
Copy link

@boutil boutil commented Feb 29, 2016

The following modifications allows one to compile and ruby rb-gsl against GSL v2.

  • change the way jacobians of fdfsolvers are computed as they are no more accessible as members of the structure
  • some elliptic functions return error code change their name, elliptic D function dropped the unused parameter n
  • fix a compiler warning about a pointer being passed instead of the value it was pointing to.

The files build without issues and test pass with ruby2.2 and ruby2.3

Let me know if you want me to modify or correct things in this PR.

This allows at least Debian to fix the transition of this package to GSL 2, and thus fixes #24 and #25

Thanks!

@boutil
Copy link
Author

boutil commented Feb 29, 2016

travis does not work, because it cannot install gsl v2 via rubygems.

@v0dro
Copy link
Member

v0dro commented Feb 29, 2016

This is great. I'm currently working on incorporating nmatrix into rb-gsl and don't want any conflicts, so I'll merge your code with mine in 2-3 days.

@v0dro
Copy link
Member

v0dro commented Feb 29, 2016

By the way, does this change break compatibility with GSL 1.15 and 1.16?

If yes, could you add guards with the macro GSL_2_LATER for whatever code that requires GSL > 2?

For example:

# ifdef GSL_2_LATER
  // some gsl 2.0 methods.
#endif

@boutil
Copy link
Author

boutil commented Mar 1, 2016 via email

@ktns
Copy link
Contributor

ktns commented Mar 1, 2016

Hi,

Many thanks for this great patch.

I've wrote an additional patch to detect whether Jacobians are pre-calculated (fbf7759).
I hope it helps.

@ktns
Copy link
Contributor

ktns commented Mar 1, 2016

Now I wrote a similar patch for gsl_sf_mathieu (c08a4a4).

I hope this also helps you.

@v0dro
Copy link
Member

v0dro commented Mar 2, 2016

@boutil will it possible for you to include changes from @ktns into your branch?

@boutil
Copy link
Author

boutil commented Mar 2, 2016 via email

@v0dro
Copy link
Member

v0dro commented Mar 4, 2016

@boutil didn't you have to make any changes to extconf to link with GSL 2.1?

@v0dro v0dro mentioned this pull request Mar 4, 2016
@boutil
Copy link
Author

boutil commented Mar 6, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gsl-2.1 breaks rb-gsl
3 participants