-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to GSL 2.0 #31
base: master
Are you sure you want to change the base?
Adapt to GSL 2.0 #31
Conversation
travis does not work, because it cannot install gsl v2 via rubygems. |
This is great. I'm currently working on incorporating nmatrix into rb-gsl and don't want any conflicts, so I'll merge your code with mine in 2-3 days. |
By the way, does this change break compatibility with GSL 1.15 and 1.16? If yes, could you add guards with the macro For example: # ifdef GSL_2_LATER
// some gsl 2.0 methods.
#endif |
Thanks for your feedback. I'll try to see what I can do in this direction.
|
Hi, Many thanks for this great patch. I've wrote an additional patch to detect whether Jacobians are pre-calculated (fbf7759). |
Now I wrote a similar patch for gsl_sf_mathieu (c08a4a4). I hope this also helps you. |
I'll work on that today.
|
@boutil didn't you have to make any changes to |
The following modifications allows one to compile and ruby rb-gsl against GSL v2.
The files build without issues and test pass with ruby2.2 and ruby2.3
Let me know if you want me to modify or correct things in this PR.
This allows at least Debian to fix the transition of this package to GSL 2, and thus fixes #24 and #25
Thanks!