Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using dither in BmpEncoder when bit per pixel is <= 4 #2819

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Fix using dither in BmpEncoder when bit per pixel is <= 4 #2819

merged 2 commits into from
Oct 12, 2024

Conversation

mistoll
Copy link
Contributor

@mistoll mistoll commented Oct 4, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This is a fix for #2817

JimBobSquarePants
JimBobSquarePants approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This great thanks.

I'll add regression tests once merged.

@JimBobSquarePants JimBobSquarePants merged commit ed2c2a1 into SixLabors:main Oct 12, 2024
5 checks passed
@JimBobSquarePants JimBobSquarePants linked an issue Oct 15, 2024 that may be closed by this pull request
BmpEncoder does not respect QuantizerOptions.Dither when BitsPerPixel is 1, 2 or 4 #2817
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitod123 vitod123 vitod123 approved these changes

@JimBobSquarePants JimBobSquarePants JimBobSquarePants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BmpEncoder does not respect QuantizerOptions.Dither when BitsPerPixel is 1, 2 or 4
3 participants
@mistoll @JimBobSquarePants @vitod123