Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol.xml #18

Closed

Conversation

Turboschlumpf
Copy link

Hi, I improved your code. Could you check :D, please?

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Auto-closing pull request. Results were forwarded to Skyline.

@github-actions github-actions bot closed this Oct 6, 2023
@janstaelensskyline
Copy link
Member

Hi there! Thank you for following along with the exercise.
I noticed that instead of fixing the protocol with the validator it looks like you've removed the content of the tag completely.

I'd love to invite you to try it again, you can take a look at https://www.youtube.com/watch?v=hE5sUrIJj2k&t=6s&ab_channel=DataMinerbySkylineCommunications

or in textual form: https://docs.dataminer.services/develop/TOOLS/DIS/Tutorials/DisDevOpsValidator.html

I think I know your DataMiner DoJo user from the contact information you added in the xml content. But to be sure, could you e-mail thunder@skyline.be with your github username?

I'll already go ahead and assign you 75 points devops points, because I love the enthusiasm in making the fork and pull request. But if you can upload the right content, I'll double it!

Thanks!

@Turboschlumpf
Copy link
Author

Turboschlumpf commented Oct 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants