Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Commit

Permalink
updates from code review, update version
Browse files Browse the repository at this point in the history
  • Loading branch information
danadesrosiers committed Mar 26, 2019
1 parent ee8f95c commit e484d13
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 9.1.0 (2019-03-?)
# 9.1.0 (2019-03-26)
### Features
* **Subscribe Retry**: Added a retry strategy for when a subscriber fails to subscribe because the Broker doesn't exist yet.
* **BrokerServiceUri**: We recently lost the ability to specify the BrokerUri when publishing/subscribing. Added the ability to pass the BrokerUri to the BrokerServiceLocator class.
Expand Down
4 changes: 2 additions & 2 deletions src/SoCreate.ServiceFabric.PubSub/BrokerServiceBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ protected BrokerServiceBase(StatefulServiceContext serviceContext, bool enableAu
{
if (enableAutoDiscovery)
{
new BrokerServiceLocator(brokerServiceUri: Context.ServiceName).RegisterAsync()
new BrokerServiceLocator(Context.ServiceName).RegisterAsync()
.ConfigureAwait(false)
.GetAwaiter()
.GetResult();
Expand All @@ -100,7 +100,7 @@ protected BrokerServiceBase(StatefulServiceContext serviceContext,
{
if (enableAutoDiscovery)
{
new BrokerServiceLocator(brokerServiceUri: Context.ServiceName).RegisterAsync()
new BrokerServiceLocator(Context.ServiceName).RegisterAsync()
.ConfigureAwait(false)
.GetAwaiter()
.GetResult();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class BrokerServiceLocator : IBrokerServiceLocator
/// <summary>
/// Creates a new default instance.
/// </summary>
public BrokerServiceLocator(IHashingHelper hashingHelper = null, Uri brokerServiceUri = null)
public BrokerServiceLocator(Uri brokerServiceUri = null, IHashingHelper hashingHelper = null)
{
_hashingHelper = hashingHelper ?? new HashingHelper();
_fabricClient = new FabricClient();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Description>SoCreate.ServiceFabric.PubSub adds pub/sub behaviour to your Reliable Actors and Services in Service Fabric. Documentation: http://service-fabric-pub-sub.socreate.it</Description>
<Copyright>© SoCreate. All rights reserved.</Copyright>
<AssemblyTitle>SoCreate.ServiceFabric.PubSub</AssemblyTitle>
<Version>9.0.0</Version>
<Version>9.1.0</Version>
<Company>SoCreate</Company>
<Authors>Loek Duys, SoCreate</Authors>
<TargetFramework>netstandard2.0</TargetFramework>
Expand Down

0 comments on commit e484d13

Please sign in to comment.