fix: prioritize important styles #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tborg
force-pushed
the
tborg-fix-merge
branch
from
b8891ca
to
554264d
Compare
CodSpeed Performance ReportMerging #398 will not alter performanceComparing Summary
|
tborg
commented
Nov 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 89.17% 89.22% +0.04%
==========================================
Files 18 18
Lines 1913 1921 +8
==========================================
+ Hits 1706 1714 +8
Misses 207 207 ☔ View full report in Codecov by Sentry. |
tborg
force-pushed
the
tborg-fix-merge
branch
from
554264d
to
2487507
Compare
tborg
force-pushed
the
tborg-fix-merge
branch
from
2487507
to
72154dd
Compare
|
Hi @Stranger6667 — very glad you were able to release 0.14.2 on Monday! Here's another patch for you — please let me know if this seems reasonable to you and whether there's anything I can do to make it better. |
|
Hi @tborg Thank you so much for fixing this :) Absolutely reasonable! I am going to make a new patch release soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two selectors would set a property for an element, if one of those selectors is important then it should take precedence over non-important selector. If they are both important, or neither are important, then specificity is enough.
I observed this issue when comparing generated emails against the output of the node
inline-csslibrary. Here's a simple playground input/output that demonstrates the problem:Note that if you reverse the order of the rule declarations, you get the correct behavior.