Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWA-98][FIX] - Update 1inch API config #317

Merged
merged 3 commits into from
Sep 29, 2023
Merged

[SWA-98][FIX] - Update 1inch API config #317

merged 3 commits into from
Sep 29, 2023

Conversation

ElRodrigote
Copy link
Collaborator

@ElRodrigote ElRodrigote commented Sep 13, 2023 •
edited
Loading

Fixes: SWA-98

Description

  • Update our 1inch Swap API config to comply with their new API changes.
  • Right now we use a proxy serverless layer to handle CORS and secrets.

@ElRodrigote ElRodrigote changed the title [SWA-98][FEAT] - Update 1inch API config [SWA-98][FIX] - Update 1inch API config Sep 13, 2023
@ElRodrigote ElRodrigote marked this pull request as draft September 14, 2023 13:52
@ElRodrigote ElRodrigote force-pushed the fix/swa-98-1inch-not-showing-as-router branch from bd880b7 to 9a793bf Compare September 28, 2023 14:16
berteotti
berteotti reviewed Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, will approve after dist is removed

@ElRodrigote ElRodrigote marked this pull request as ready for review September 29, 2023 12:39
berteotti
berteotti approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Rorry!

@ElRodrigote ElRodrigote merged commit 451fb14 into develop Sep 29, 2023
1 check failed
berteotti pushed a commit that referenced this pull request Oct 23, 2023
@ElRodrigote @berteotti
fix(SWA-98): Update 1inch API config (#317)
f8b19c5 
* fix(SWA-98): fix our code to fit latest 1inch API changes
berteotti pushed a commit that referenced this pull request Oct 23, 2023
@ElRodrigote @berteotti
fix(SWA-98): Update 1inch API config (#317)
d40321e 
* fix(SWA-98): fix our code to fit latest 1inch API changes
@ElRodrigote ElRodrigote deleted the fix/swa-98-1inch-not-showing-as-router branch February 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berteotti berteotti berteotti approved these changes

@NelsonGaldeman NelsonGaldeman Awaiting requested review from NelsonGaldeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElRodrigote @berteotti