[SWA-134][IMPROVEMENT] - Fix CoW Trade type errors #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from ethers to enable treeshaking
…ate CoW SDK types
Diogomartf
approved these changes
Jan 15, 2024
This reverts commit 497a787.
berteotti
reviewed
Jan 16, 2024
Comment on lines
27
to
33
| enum CowChainId { | ||
| MAINNET = 1, | ||
| RINKEBY = 4, | ||
| GOERLI = 5, | ||
| GNOSIS = 100, | ||
| SEPOLIA = 11155111, | ||
| } |
There was a problem hiding this comment.
Is it possible to import this values?
There was a problem hiding this comment.
Yes! Already did it! Also added Sepolia to our ChainID constant
There was a problem hiding this comment.
Sorry, I was to vague. Import this values from cow-sdk. They must have their own ChaindId on the SDK
There was a problem hiding this comment.
As we talked offline:
We will keep the current version of the code as CoW SDK provides a ChainID enum that lacks some of the chain IDs needed for this use case.
berteotti
approved these changes
Jan 17, 2024
ElRodrigote
deleted the
improvement/swa-134-swapr-sdk-fix-cowtrade-type-errors
branch
berteotti
pushed a commit
that referenced
this pull request
Feb 1, 2024
* improv(SWA-134): install prettier and run the linter with fixes * improv(SWA-134): ran linter in new Swapr V3 files, change import path from ethers to enable treeshaking * improv(SWA-134): remove unneeded linter disables, update imports, update CoW SDK types * chore(SWA-134): PR comment to abstract numbers into ChainId
ElRodrigote
added a commit
that referenced
this pull request
Feb 1, 2024
* improv(SWA-134): install prettier and run the linter with fixes * improv(SWA-134): ran linter in new Swapr V3 files, change import path from ethers to enable treeshaking * improv(SWA-134): remove unneeded linter disables, update imports, update CoW SDK types * chore(SWA-134): PR comment to abstract numbers into ChainId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: SWA-134
Description