Update #6
Merged
Update #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1213 In addition switch to modern button events here. "pressed" and "released" are deprecated since GTK 2.8.
…s: #1214 Alt+I is already the shortcut to open the Song Info dialog. Menu bar items should use a different mnemonic character.
Although ID3 and a number of tagging schemes do not support disc numbers - Disc numbers can be an integral part of tagging for multi-disc albums, especially Classical music. This implements feature request #603. Signed-off-by: Andrew Thornton <art27@cantab.net>
This was missed in commit 397b4fd.
CYGWIN uses shared libraries with ".dll" extension like Windows. This patch fixes meson.build for setting PLUGIN_SUFFIX to the correct value for this platform.
Waveout driver can be compiled without troubles on CYGWIN. This fix allows to use the player without using SDL or PortAudio, if the user wants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.