-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add categories DataProcessor #653
Open
schloram
wants to merge
18
commits into
TYPO3-Headless:master
Choose a base branch
from
schloram:add-categories-dataprocessor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[FEATURE] Add categories DataProcessor #653
schloram
wants to merge
18
commits into
TYPO3-Headless:master
from
schloram:add-categories-dataprocessor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, please fix codestyle and tests and we can merge it then :) |
Pull Request Test Coverage Report for Build 7250772858
💛 - Coveralls |
lukaszuznanski
force-pushed
the
add-categories-dataprocessor
branch
from
May 9, 2024 14:37
b496331
to
282c84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this DataProcessor we can get rid of the chunky categories TypoScript. Plus this one is easier to re-use.
Additionally to that I also re-formatted the output of the categories since we always thought that the comma-separated list is unnecessary if the data is already structured. The frontend always had to split the string into an array themselves (we never could use the string as is).
This is why I also changes the output from comma-separated list to an array of objects in the following format:
Example usage (get categories by relation record):
Example usage (get categories by comma-separated-list of category ids):