Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☄️ Comprehensive Bugfixing / Maintainance PR #82

Open
wants to merge 5 commits into
base: js
Choose a base branch
from

Conversation

sidneys
Copy link

@sidneys sidneys commented Jun 7, 2018

Target platforms this affects:

  • Linux
  • Mac
  • Windows

What problem does this solve?

  • Up-to-date fixes and maintainance, based on recent 'js' branch
  • Bugfix: Fixes scoping error within getPath() ('js' branch)
  • package.json: Fixes "main" filepath to index.js
  • package.json: bumps minimum Node engine to 8.0.0
  • package.json: adds correct repository info (4ver -> Teamwork)
  • package.json: Upgrades modules dependencies with vulnerabilities, adds yarn lockfile
  • LinuxAutoLauncher: fixes quotes in Linux .desktop entry

Could it break any existing functionality for users?

  • No

@adam-lynch
@4ver
@edulan
Thanks for a great module which needed some attention 🥇 🥇 🥇

@sidneys sidneys changed the base branch from master to js June 7, 2018 21:10
@adam-lynch
Copy link
Contributor

Thanks for this @sidneys. I've invited you a collaborator to this project. This means you can merge pull requests, close issues, etc. Let me know once you (hopefully) accept the invite. I'm going to invite more people and add a list of contributors/maintainers somewhere (maybe the README)

@ffflorian
Copy link
Collaborator

Are there any updates on this? I would also jump in as maintainer / collaborator.

@adam-lynch
Copy link
Contributor

@ffflorian no updates sorry but I have invited you to be a maintainer. See https://github.com/Teamwork/node-auto-launch/invitations. Thanks for your help! 👍

@yafp
Copy link

yafp commented Jan 9, 2020

any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants