Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to guard against nil properties. #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tonycpsu
Copy link

There seems to be a race condition (see #19) when a file is loaded where some
properties are set and then later read as nil. This attempts to fix
this by saving non-nil properties to the global state and reading from
that. Seems to eliminate the problem so far.

There seems to be a race condition when a file is loaded where some
properties are set and then later read as nil.  This attempts to fix
this by saving non-nil properties to the global state and reading from
that.  Seems to eliminate the problem so far.
@tonycpsu
Copy link
Author

Eh, I don't think this is a full fix just yet. The issues with video-dec-params and path have gone away, but I think it just pushes the race condition problem elsewhere in the code. Now I get things like: Lua error: ...nyc/.mpv/scripts/mpv_thumbnail_script_client_osc.lua:890: bad argument #1 to 'max' (number expected, got nil). Getting errors far less often, but still getting them. @TheAMM , do you have any pointers on where to look for the problem?

@picarica
Copy link

picarica commented Feb 7, 2020

i have similar problem maybe related to this issue
[mpv_thumbnail_script_client_osc] Lua error: .../.config/mpv/scriptsmpv_thumbnail_script_client_osc.lua:1080: attempt to compare nil with number
more info mentioned here
these are my logs is there some correlation ?

@blankname
Copy link

@tonycpsu
Do all of the problems you encounter happen shortly after changing videos?

#54 Should fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants