Add libs.versions.toml version library #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set jdk distribution to temurin
android build tools 33.0.0 -> 34.0.0 skiko 0.7.26 -> 0.7.72 webpackCli 4.10.0 -> 5.1.4 node 16.0.0 -> 16.13.0
kotlin-dsl gradle-plugin 1.8.20 -> 1.9.0 These can be hard to miss when versioning in the Version.kt file so I add a note there
Need to set optin on ComposeWindow.kt on MacOS and set JVM to 17
replacing android
replaces buildSrc
Needed to remove `binaries.executable()` from js block in viewmodel and todo sample.
not sure if this will work on the CI
window resize now handled by ComposeWindow.js.kt
--no-daemon Is faster when running only one gradle command but probably slower when running subsequent commands. I could be wrong though. --no-parallel slows down builds on a 3 core mac on GitHub
and remove extra jupiter library references
Performing static analysis on a separate linux machine to reduce cost. Only starts the mac machine if static validation passes. Results from validations and tests are stored. Looks like release and debug versions of things were being run so setting to the Release variants of assemble and test.
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
fixing a merge error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a version library.
Changes to the GitHub Actions CI configuration.
I believe it will now be faster and lower cost but it's possible that there are side effects I'm not aware of.
Now uploads reports from lint and testing
https://github.com/SquidTooth/PreCompose/actions/runs/5722641066
closes #79