-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Code Reviews
Beat Buesser edited this page Oct 3, 2021
·
3 revisions
-
Pull request require approval by a reviewers assigned by one of the maintainers.
-
Approved pull requests will be merged by one of the maintainers.
-
Reviewers should aim to understand every change of code and ask what the changes goals are and how it accomplishes them.
-
Reviewers should not assume that the code works, but should run and test it themselves.
-
Reviewers should comment code and ask questions, especially to detect cases where intent does not match code logic, etc.
-
Reviewers should consider all code as production code.
-
Reviewers should also check tests and documentation.
-
Reviewers should be prepared to review again after the contributors reaction to the first review.