Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EA to public files #1026

Merged
merged 1 commit into from
Apr 8, 2024
Merged

EA to public files #1026

merged 1 commit into from
Apr 8, 2024

Conversation

CasperH2O
Copy link
Collaborator

@CasperH2O CasperH2O commented Apr 8, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Enhanced setup process with new directives and definitions for dependencies like .NET, DirectX, and more.
    • Improved logic for checking and updating component versions during setup.

  • Refactor

    • Reformatted code across multiple files for better readability and consistency.
    • Organized namespace and class declarations in device-specific files.

  • Style

    • Adjusted formatting, including spacing and line breaks, in various classes and files.

  • Documentation

    • Added comments and improved whitespace usage for clearer code structure.

  • Bug Fixes

    • Corrected namespace declaration in AYANEO2S.cs.

  • Chores

    • Minor adjustments in XAML markup for user controls to enhance UI elements' initial visibility.

@CasperH2O CasperH2O merged commit 71b7586 into Valkirie:main Apr 8, 2024
1 check passed
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 8, 2024 •
edited
Loading

Walkthrough

The bulk of the recent updates to the Handheld Companion project primarily revolve around code reformatting and organization, aimed at enhancing readability and maintainability. Key setup script enhancements in HandheldCompanion.iss include significant revisions to setup directives and components' handling. Meanwhile, most other changes across various files and classes involve no functional alterations but focus on improving the code structure through whitespace adjustments and formatting.

Changes

File Path Change Summary
HandheldCompanion.iss Significant modifications to setup section, addition of setup directives, components definitions, and logic for handling dependencies.
HandheldCompanion/ADLX/...
HandheldCompanion/Actions/...
HandheldCompanion/App.xaml.cs
HandheldCompanion/Controllers/...
HandheldCompanion/Controls/Hints/...
HandheldCompanion/Converters/...
HandheldCompanion/Devices/...		 No functional changes; formatting adjustments like spacing, line breaks, and reorganization.
HandheldCompanion/Devices/AYANEO/AYANEODevice.cs
HandheldCompanion/Devices/AYANEO/AYANEODeviceCEc.cs		 Adjustments to methods for setting LED status, brightness, and color; improvements in battery level tracking.

🐇✨
In the realm of code, where rabbits hop,
A tidy garden, each line, each crop.
No leaf unturned, no vine astray,
In Handheld's land, it's brighter day.
With every change, a cleaner sweep,
Through lines of code, our leaps are deep.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b80c6dc and ae854bd.
Files ignored due to path filters (1)
  • redist/RTSSSetup735.exe is excluded by !**/*.exe
Files selected for processing (53)
  • HandheldCompanion.iss (12 hunks)
  • HandheldCompanion/ADLX/ADLXBackend.cs (1 hunks)
  • HandheldCompanion/Actions/GyroActions.cs (1 hunks)
  • HandheldCompanion/Actions/MouseActions.cs (1 hunks)
  • HandheldCompanion/App.xaml.cs (1 hunks)
  • HandheldCompanion/Controllers/DInputController.cs (1 hunks)
  • HandheldCompanion/Controllers/DS4Controller.cs (1 hunks)
  • HandheldCompanion/Controllers/DualSenseController.cs (1 hunks)
  • HandheldCompanion/Controllers/GordonController.cs (1 hunks)
  • HandheldCompanion/Controllers/IController.xaml (1 hunks)
  • HandheldCompanion/Controllers/IController.xaml.cs (1 hunks)
  • HandheldCompanion/Controllers/JSController.cs (1 hunks)
  • HandheldCompanion/Controllers/NeptuneController.cs (1 hunks)
  • HandheldCompanion/Controllers/ProController.cs (1 hunks)
  • HandheldCompanion/Controllers/SteamController.cs (1 hunks)
  • HandheldCompanion/Controllers/XInputController.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_AMD_IntegerScalingCheck.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_CoreIsolationCheck.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_LegionGoLegionSpace.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_MSIClawCenter.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_RogAllyServiceCheck.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_SteamNeptuneDesktop.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/Hint_SteamXboxDrivers.cs (1 hunks)
  • HandheldCompanion/Controls/Hints/IHint.xaml (1 hunks)
  • HandheldCompanion/Controls/Hints/IHint.xaml.cs (1 hunks)
  • HandheldCompanion/Converters/InverseAppThemeConverter.cs (1 hunks)
  • HandheldCompanion/Converters/InvertPercentageConverter.cs (1 hunks)
  • HandheldCompanion/Devices/AOKZOE/AOKZOEA1Pro.cs (1 hunks)
  • HandheldCompanion/Devices/ASUS/AsusACPI.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEO2021Pro.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEO2S.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOAIR1S.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRLite.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPlusAMD.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPlusAMDMendocino.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPlusIntel.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPro.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEODevice.cs (3 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEODeviceCEc.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEODeviceCEii.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEONEXTLite.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEONEXTLite4500U.cs (1 hunks)
  • HandheldCompanion/Devices/AYANEO/AYANEOSLIDE.cs (1 hunks)
  • HandheldCompanion/Devices/Ayn/AynLokiMax6600U.cs (1 hunks)
  • HandheldCompanion/Devices/Ayn/AynLokiMax6800U.cs (1 hunks)
  • HandheldCompanion/Devices/Ayn/AynLokiMiniPro.cs (1 hunks)
  • HandheldCompanion/Devices/Ayn/AynLokiZero.cs (1 hunks)
  • HandheldCompanion/Devices/DefaultDevice.cs (1 hunks)
  • HandheldCompanion/Devices/GPD/GPDWin2.cs (1 hunks)
  • HandheldCompanion/Devices/GPD/GPDWinMax2AMD.cs (1 hunks)
  • HandheldCompanion/Devices/GPD/GPDWinMax2Intel.cs (1 hunks)
  • HandheldCompanion/Devices/GPD/GPDWinMini-7640U.cs (1 hunks)
  • HandheldCompanion/Devices/GPD/GPDWinMini-7840U.cs (1 hunks)
Files not processed due to max files limit (14)
  • HandheldCompanion/Devices/Lenovo/FanTable.cs
  • HandheldCompanion/Devices/Lenovo/LegionGo.cs
  • HandheldCompanion/Devices/Lenovo/SapientiaUsb.cs
  • HandheldCompanion/Devices/OneXPlayer/OneXPlayer2Pro.cs
  • HandheldCompanion/Devices/OneXPlayer/OneXPlayerMiniAMD.cs
  • HandheldCompanion/Devices/OneXPlayer/OneXPlayerMiniIntel.cs
  • HandheldCompanion/Extensions/GlyphExtensions.cs
  • HandheldCompanion/Extensions/ManagementObjectSearcherExtensions.cs
  • HandheldCompanion/Extensions/UIThreadExtensions.cs
  • HandheldCompanion/GraphicsProcessingUnit/AMDGPU.cs
  • HandheldCompanion/GraphicsProcessingUnit/GPU.cs
  • HandheldCompanion/GraphicsProcessingUnit/IntelGPU.cs
  • HandheldCompanion/HandheldCompanion.csproj
  • HandheldCompanion/HandheldCompanion.json
Files skipped from review due to trivial changes (50)
  • HandheldCompanion/ADLX/ADLXBackend.cs
  • HandheldCompanion/Actions/GyroActions.cs
  • HandheldCompanion/Actions/MouseActions.cs
  • HandheldCompanion/App.xaml.cs
  • HandheldCompanion/Controllers/DInputController.cs
  • HandheldCompanion/Controllers/DS4Controller.cs
  • HandheldCompanion/Controllers/DualSenseController.cs
  • HandheldCompanion/Controllers/GordonController.cs
  • HandheldCompanion/Controllers/IController.xaml
  • HandheldCompanion/Controllers/IController.xaml.cs
  • HandheldCompanion/Controllers/JSController.cs
  • HandheldCompanion/Controllers/NeptuneController.cs
  • HandheldCompanion/Controllers/ProController.cs
  • HandheldCompanion/Controllers/SteamController.cs
  • HandheldCompanion/Controllers/XInputController.cs
  • HandheldCompanion/Controls/Hints/Hint_AMD_IntegerScalingCheck.cs
  • HandheldCompanion/Controls/Hints/Hint_CoreIsolationCheck.cs
  • HandheldCompanion/Controls/Hints/Hint_LegionGoLegionSpace.cs
  • HandheldCompanion/Controls/Hints/Hint_MSIClawCenter.cs
  • HandheldCompanion/Controls/Hints/Hint_RogAllyServiceCheck.cs
  • HandheldCompanion/Controls/Hints/Hint_SteamNeptuneDesktop.cs
  • HandheldCompanion/Controls/Hints/Hint_SteamXboxDrivers.cs
  • HandheldCompanion/Controls/Hints/IHint.xaml
  • HandheldCompanion/Controls/Hints/IHint.xaml.cs
  • HandheldCompanion/Converters/InverseAppThemeConverter.cs
  • HandheldCompanion/Converters/InvertPercentageConverter.cs
  • HandheldCompanion/Devices/AOKZOE/AOKZOEA1Pro.cs
  • HandheldCompanion/Devices/ASUS/AsusACPI.cs
  • HandheldCompanion/Devices/AYANEO/AYANEO2021Pro.cs
  • HandheldCompanion/Devices/AYANEO/AYANEO2S.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOAIR1S.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRLite.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPlusAMD.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPlusAMDMendocino.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPlusIntel.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOAIRPro.cs
  • HandheldCompanion/Devices/AYANEO/AYANEODeviceCEii.cs
  • HandheldCompanion/Devices/AYANEO/AYANEONEXTLite.cs
  • HandheldCompanion/Devices/AYANEO/AYANEONEXTLite4500U.cs
  • HandheldCompanion/Devices/AYANEO/AYANEOSLIDE.cs
  • HandheldCompanion/Devices/Ayn/AynLokiMax6600U.cs
  • HandheldCompanion/Devices/Ayn/AynLokiMax6800U.cs
  • HandheldCompanion/Devices/Ayn/AynLokiMiniPro.cs
  • HandheldCompanion/Devices/Ayn/AynLokiZero.cs
  • HandheldCompanion/Devices/DefaultDevice.cs
  • HandheldCompanion/Devices/GPD/GPDWin2.cs
  • HandheldCompanion/Devices/GPD/GPDWinMax2AMD.cs
  • HandheldCompanion/Devices/GPD/GPDWinMax2Intel.cs
  • HandheldCompanion/Devices/GPD/GPDWinMini-7640U.cs
  • HandheldCompanion/Devices/GPD/GPDWinMini-7840U.cs
Additional comments not posted (10)
HandheldCompanion/Devices/AYANEO/AYANEODevice.cs (3)

9-14: Adding AYA to the LEDGroup enum aligns with expanding device support. Good addition.

27-46: The addition of GetGlyph method enhances functionality by providing glyph mapping for button flags. Well-implemented.

73-94: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [47-91]

Updates to PowerManager_PowerStatusChanged improve battery level tracking and consistency in using this references. Removal of LED color setting logic likely aligns with refining device management.

HandheldCompanion/Devices/AYANEO/AYANEODeviceCEc.cs (4)

79-98: Adjustments to SetLedStatus method enhance LED control based on device status. Good update.

101-114: Enhancements in SetLedBrightness method for controlling LED brightness based on provided value. Well-implemented.

118-147: Updates to SetLedColor method allow for more flexible LED color settings, aligning with device customization needs.

152-217: The addition of private methods for detailed LED control (CEcRgb_GlobalOn, CEcRgb_GlobalOff, etc.) supports the enhanced LED functionality. These methods provide a solid foundation for the public-facing LED control methods.

HandheldCompanion.iss (3)

1-63: Updates to setup directives and component definitions, including new components and version information, enhance the setup process by ensuring the latest versions of essential components are installed.

164-226: The introduction of new functions for dependency management streamlines the setup process by handling dependencies more effectively.

137-139: Adjustments to registry settings for error reporting and uninstallation behavior contribute to better error handling and cleanup.

@CasperH2O CasperH2O deleted the EaToPublicFiles branch April 19, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CasperH2O