Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added parameter validation to feature selection #129

Merged
merged 1 commit into from
Oct 18, 2024
Merged

added parameter validation to feature selection #129

merged 1 commit into from
Oct 18, 2024

Conversation

mstaniak
Copy link
Contributor

Motivation and Context

#96

Changes

  • added an assert for feature selection method parameter

Testing

none

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • [x ] Any dependent changes have been merged and published in downstream modules

@mstaniak mstaniak merged commit 042f32f into devel Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devonjkohler devonjkohler devonjkohler approved these changes

@tonywu1999 tonywu1999 tonywu1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstaniak @tonywu1999 @devonjkohler