Batch Refactor #521
Draft
Batch Refactor #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apchytr
added
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Currently in develop, there is no interface explicitly defined for the handling of batch dims. This makes things such as adding new batch dimensions (e.g. for measurement outcomes) difficult. Additionally, we wish to introduce the concept of "batch labels" where ideally some class is responsible for the handling of batch labels. As such, in this PR we introduce the
Batchclass.Description of the Change: Introduce the
Batchclass.Benefits: Having a concrete interface means a cleaner, safer implementation of batching where we can now define arbitrary batch dims and attribute batch labels to them (for mrm einsum).