Added the ability to control slackness in physicality conditions. #524
+42
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsalan-motamedi
added
the
no changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #524 +/- ##
===========================================
- Coverage 89.81% 89.80% -0.02%
===========================================
Files 93 93
Lines 6098 6092 -6
===========================================
- Hits 5477 5471 -6
Misses 621 621
Continue to review full report in Codecov by Sentry.
|
apchytr
reviewed
Nov 18, 2024
| @@ -49,10 +49,12 @@ class DM(State): | |||
|
|
|||
| short_name = "DM" | |||
|
|
|||
| @property | |||
| def is_positive(self) -> bool: | |||
| def is_positive(self, atol: float = settings.ATOL) -> bool: | |||
There was a problem hiding this comment.
Rather than adding a parameter what if instead we encouraged users to use
with settings(ATOL=1e-8):
...
Of course we would then have to make that clear in our documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently, the tolerance for channel CPTP conditions, density matrix positivity and trace conditions, and pure state norm conditions use
settings.ATOLto control their slackness. This PR allows to use arbitrary slackness for them.Description of the Change:
Introduced new variable
atol: float = settings.ATOLwhich is to control this slackness in all physicality conditions includingis_CP,is_TP, andis_physicalfor Channels, andis_positiveandis_physicalfor DMs, and finally,is_physicalfor Kets.Benefits:
Will be convenient to set the slackness. Also, is helpful in some tests.
Possible Drawbacks:
None.
Related GitHub Issues:
None.