Skip to content

Commit

Permalink
chore: Update todos
Browse files Browse the repository at this point in the history
  • Loading branch information
DashieTM committed Jun 12, 2024
1 parent e7c0995 commit ee71290
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 16 deletions.
2 changes: 1 addition & 1 deletion src/components/audio/audio_box_utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ pub fn start_audio_box_listener<
get_default_name_function: &'static DBusFunction,
dummy_name: &'static str,
) -> Connection {
// TODO: make the failed logs generically sound -> deynamic output for both
// FUTURE TODO: make the failed logs generically sound -> deynamic output for both
let object_added =
ObjectAdded::match_rule(Some(&BASE.into()), Some(&Path::from(DBUS_PATH))).static_clone();
let object_changed =
Expand Down
2 changes: 1 addition & 1 deletion src/components/audio/audio_entry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pub fn new_entry<
reset_box: Arc<AudioBox>,
) -> Arc<AudioEntry> {
let obj: Arc<AudioEntry> = Arc::new(Object::builder().build());
// TODO use event callback for progress bar -> this is the "im speaking" indicator
// FUTURE TODO: use event callback for progress bar -> this is the "im speaking" indicator
{
let imp = obj.entry_imp();
let slider_obj_ref = obj.clone();
Expand Down
2 changes: 1 addition & 1 deletion src/components/audio/audio_functions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ pub fn new_stream_entry<
stream: StreamObject,
) -> Arc<AudioStream> {
let obj: Arc<AudioStream> = Arc::new(Object::builder().build());
// TODO use event callback for progress bar -> this is the "im speaking" indicator
// FUTURE TODO: use event callback for progress bar -> this is the "im speaking" indicator
let output_box_mute_ref = audio_box.clone();
let output_box_volume_ref = audio_box.clone();
let output_box_sink_ref = audio_box.clone();
Expand Down
2 changes: 1 addition & 1 deletion src/components/base/error_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub fn show_error<T: ReSetErrorImpl + Send + Sync + 'static>(
parent: Arc<T>,
message: &'static str,
) {
// TODO: Add error to log
// FUTURE TODO: Add error to log
glib::spawn_future(async move {
glib::idle_add_once(move || {
let error = parent.error();
Expand Down
3 changes: 1 addition & 2 deletions src/components/bluetooth/bluetooth_box.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ impl BluetoothBox {
}
}

// TODO
// FUTURE TODO:
// handle bonded -> this means saved but not connected
// handle rssi below x -> don't show device

Expand Down Expand Up @@ -185,7 +185,6 @@ pub fn populate_connected_bluetooth_devices(
listeners: Arc<Listeners>,
bluetooth_box: Arc<BluetoothBox>,
) {
// TODO handle saved devices -> they also exist
gio::spawn_blocking(move || {
let ref_box = bluetooth_box.clone();
let adapters = get_bluetooth_adapters(ref_box.clone());
Expand Down
2 changes: 1 addition & 1 deletion src/components/bluetooth/bluetooth_entry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl BluetoothEntry {
});
let gesture = GestureClick::new();
// paired is not what we think
// TODO implement paired
// FUTURE TODO: implement paired
gesture.connect_released(move |_, _, _, _| {
let imp = entry_ref.imp();
let borrow = imp.bluetooth_device.borrow();
Expand Down
2 changes: 1 addition & 1 deletion src/components/bluetooth/bluetooth_event_handlers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ pub fn device_removed_handler(
if list_entry.imp().bluetooth_device.borrow().connected {
imp.reset_bluetooth_connected_devices.remove(&*list_entry);
} else {
// TODO: is there a better way for this?
// FUTURE TODO: is there a better way for this?
imp.reset_bluetooth_available_devices.remove(&*list_entry);
imp.reset_bluetooth_saved_devices.remove(&*list_entry);
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/wifi/saved_wifi_entry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ impl SavedWifiEntry {
let entry_ref = entry.clone();
delete_button.connect_clicked(clone!(@weak wifi_box => move |_| {
delete_connection(entry_ref.imp().reset_connection_path.take());
// TODO handle error
// FUTURE TODO: handle error
wifi_box.reset_stored_wifi_list.remove(&*entry_ref);

}));
Expand Down
2 changes: 1 addition & 1 deletion src/components/wifi/wifi_box.rs
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ pub fn show_stored_connections(wifi_box: Arc<WifiBox>) {
glib::idle_add_once(move || {
let self_imp = wifibox_ref.imp();
for connection in connections {
// TODO include button for settings
// FUTURE TODO: include button for settings
let name =
&String::from_utf8(connection.1).unwrap_or_else(|_| String::from(""));
let entry = SavedWifiEntry::new(name, connection.0, self_imp);
Expand Down
6 changes: 3 additions & 3 deletions src/components/wifi/wifi_entry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl WifiEntry {
.build(),
);

// TODO handle encryption thing
// FUTURE TODO: handle encryption
let wifi_strength = Image::builder()
.icon_name(match strength {
WifiStrength::Excellent => "network-wireless-signal-excellent-symbolic",
Expand Down Expand Up @@ -177,7 +177,7 @@ pub fn click_stored_network(entry: Arc<WifiEntry>) {
});
});
});
// TODO crate spinner animation and block UI
// FUTURE TODO: crate spinner animation and block UI
}

pub fn click_new_network(entry: Arc<WifiEntry>) {
Expand Down Expand Up @@ -228,7 +228,7 @@ pub fn click_new_network(entry: Arc<WifiEntry>) {
});
});
});
// TODO crate spinner animation and block UI
// FUTURE TODO: crate spinner animation and block UI
};

let entry_imp = entry.imp();
Expand Down
2 changes: 1 addition & 1 deletion src/components/wifi/wifi_event_handlers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ pub fn access_point_changed_handler(wifi_box: Arc<WifiBox>, ir: AccessPointChang
let name = name_opt.as_str();
entry_imp.wifi_strength.set(strength);
entry.set_title(name);
// TODO handle encryption thing
// FUTURE TODO: handle encryption thing
entry_imp
.reset_wifi_strength
.borrow()
Expand Down
1 change: 0 additions & 1 deletion src/components/window/reset_window.rs
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@ impl ReSetWindow {
.connect_row_activated(clone!(@ weak self_imp => move |_, _| {
self_imp.reset_search_entry.set_text("");
}));
// TODO: refactor this
let mut i = 0;
for info in sidebar_list {
if info.parent.is_none() && i != 0 {
Expand Down
2 changes: 1 addition & 1 deletion src/components/window/sidebar_entry_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use crate::components::window::sidebar_entry;

#[derive(Default)]
pub enum Categories {
// TODO: are these ever used ?
// FUTURE TODO: are these ever used ?
// Connectivity,
// Audio,
// Peripherals,
Expand Down

0 comments on commit ee71290

Please sign in to comment.