Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix autofocus of dropdown following downshift update #1921

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

Powerplex
Copy link
Contributor

Description, Motivation and Context

Downshift 8.3.2 introduced a focus issue where the last dropdown on the page gets focus on first rerender.

It has been fixed today with 8.3.3: downshift-js/downshift#1575

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (4952bed) to head (16a2261).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1921   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         740      740           
  Lines        5481     5481           
  Branches     1965     1965           
=======================================
  Hits         5381     5381           
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Powerplex Powerplex merged commit 3f6b258 into main Mar 1, 2024
10 of 11 checks passed
@Powerplex Powerplex deleted the fix-downshift-autofocus branch March 1, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants